From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sander Vanheule <sander@svanheule.net>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Michael Walle <michael@walle.cc>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/7] pinctrl: Add RTL8231 pin control and GPIO support
Date: Tue, 18 May 2021 00:42:43 +0300 [thread overview]
Message-ID: <CAHp75Vf0Qo-hBUAOwhxGiH6azFg0OPV8OkUSfTxWet__MBF9yA@mail.gmail.com> (raw)
In-Reply-To: <041077d195f1cc81bf6363388cb4adfb06cff4ef.1621279162.git.sander@svanheule.net>
On Mon, May 17, 2021 at 10:28 PM Sander Vanheule <sander@svanheule.net> wrote:
>
> This driver implements the GPIO and pin muxing features provided by the
> RTL8231. The device should be instantiated as an MFD child, where the
> parent device has already configured the regmap used for register
> access.
>
> Although described in the bindings, pin debouncing and drive strength
> selection are currently not implemented. Debouncing is only available
> for the six highest GPIOs, and must be emulated when other pins are used
> for (button) inputs anyway.
...
> +struct rtl8231_pin_desc {
> + unsigned int number;
> + const char *name;
> + enum rtl8231_pin_function functions;
> + u8 reg;
> + u8 offset;
> + u8 gpio_function_value;
> +};
I would see rather
sturct pinctrl_pin_desc desc;
Where drv_data describes the rest of the data for pin
...
> +static int rtl8231_get_group_pins(struct pinctrl_dev *pctldev, unsigned int selector,
> + const unsigned int **pins, unsigned int *num_pins)
> +{
> + if (selector < ARRAY_SIZE(rtl8231_pins)) {
Can we use traditional pattern, i.e.
if (... >= ARRAY_SIZE(...))
return -EINVAL;
...
return 0;
?
> + *pins = &rtl8231_pins[selector].number;
> + *num_pins = 1;
> + return 0;
> + }
> +
> + return -EINVAL;
> +}
...
> +static int rtl8231_set_mux(struct pinctrl_dev *pctldev, unsigned int func_selector,
> + unsigned int group_selector)
> +{
> + int err = 0;
Redundant variable.
> + switch (func_flag) {
> + case RTL8231_PIN_FUNCTION_LED:
> + case RTL8231_PIN_FUNCTION_PWM:
> + err = regmap_update_bits(ctrl->map, desc->reg, function_mask, ~gpio_function);
> + break;
> + case RTL8231_PIN_FUNCTION_GPIO:
> + err = regmap_update_bits(ctrl->map, desc->reg, function_mask, gpio_function);
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + return err;
> +}
...
> +static const struct pinmux_ops rtl8231_pinmux_ops = {
> + .set_mux = rtl8231_set_mux,
> + .get_functions_count = rtl8231_get_functions_count,
> + .get_function_name = rtl8231_get_function_name,
> + .get_function_groups = rtl8231_get_function_groups,
> + .gpio_request_enable = rtl8231_gpio_request_enable,
> + .strict = true
Leave comma for non-terminator entries.
> +};
> +
> +
One blank line is enough.
...
> +static int rtl8231_pinctrl_init_functions(struct device *dev, struct rtl8231_pin_ctrl *ctrl)
> +{
> + struct rtl8231_function *function;
> + const char **group_name;
> + unsigned int f_idx;
> + unsigned int pin;
> +
> + ctrl->nfunctions = ARRAY_SIZE(rtl8231_pin_function_names);
> + ctrl->functions = devm_kcalloc(dev, ctrl->nfunctions, sizeof(*ctrl->functions), GFP_KERNEL);
> + if (IS_ERR(ctrl->functions)) {
Wrong.
> + dev_err(dev, "failed to allocate pin function descriptors\n");
Noisy message, user space will print the similar.
> + return PTR_ERR(ctrl->functions);
> + }
> +
> + for (f_idx = 0; f_idx < ctrl->nfunctions; f_idx++) {
> + function = &ctrl->functions[f_idx];
> + function->name = rtl8231_pin_function_names[f_idx];
> +
> + for (pin = 0; pin < ctrl->pctl_desc.npins; pin++)
> + if (rtl8231_pins[pin].functions & BIT(f_idx))
> + function->ngroups++;
> +
> + function->groups = devm_kcalloc(dev, function->ngroups,
> + sizeof(*function->groups), GFP_KERNEL);
> + if (IS_ERR(function->groups)) {
> + dev_err(dev, "failed to allocate pin function group names\n");
> + return PTR_ERR(function->groups);
> + }
Ditto.
> + group_name = function->groups;
> + for (pin = 0; pin < ctrl->pctl_desc.npins; pin++)
> + if (rtl8231_pins[pin].functions & BIT(f_idx))
> + *group_name++ = rtl8231_pins[pin].name;
> + }
> +
> + return 0;
> +}
> +
> +static int rtl8231_pinctrl_init(struct device *dev, struct rtl8231_pin_ctrl *ctrl)
> +{
> + struct pinctrl_dev *pctl;
> + struct pinctrl_pin_desc *pins;
> + unsigned int pin;
> + int err = 0;
Check entire series for unnecessary assignments.They
> +
> + ctrl->pctl_desc.name = "rtl8231-pinctrl",
> + ctrl->pctl_desc.owner = THIS_MODULE,
> + ctrl->pctl_desc.pctlops = &rtl8231_pinctrl_ops,
> + ctrl->pctl_desc.pmxops = &rtl8231_pinmux_ops,
> +
> + ctrl->pctl_desc.npins = ARRAY_SIZE(rtl8231_pins);
> + pins = devm_kcalloc(dev, ctrl->pctl_desc.npins, sizeof(*pins), GFP_KERNEL);
> + if (IS_ERR(pins)) {
> + dev_err(dev, "failed to allocate pin descriptors\n");
> + return PTR_ERR(pins);
> + }
Ditto.
> + ctrl->pctl_desc.pins = pins;
> +
> + for (pin = 0; pin < ctrl->pctl_desc.npins; pin++) {
> + pins[pin].number = rtl8231_pins[pin].number;
> + pins[pin].name = rtl8231_pins[pin].name;
> + }
> +
> + err = rtl8231_pinctrl_init_functions(dev, ctrl);
> + if (err)
> + return err;
> +
> + err = devm_pinctrl_register_and_init(dev->parent, &ctrl->pctl_desc, ctrl, &pctl);
> + if (err) {
> + dev_err(dev, "failed to register pin controller\n");
> + return err;
> + }
> +
> + err = pinctrl_enable(pctl);
> + if (err)
> + dev_err(dev, "failed to enable pin controller\n");
> +
> + return err;
> +}
> +
> +/*
> + * GPIO controller functionality
> + */
> +static int rtl8231_gpio_reg_mask_xlate(struct gpio_regmap *gpio, unsigned int base,
> + unsigned int offset, unsigned int *reg, unsigned int *mask)
> +{
> + unsigned int pin_mask = BIT(offset % RTL8231_BITS_VAL);
> +
> + if (base == RTL8231_REG_GPIO_DATA0 || offset < 32) {
> + *reg = base + offset / RTL8231_BITS_VAL;
> + *mask = pin_mask;
> + } else if (base == RTL8231_REG_GPIO_DIR0) {
> + *reg = RTL8231_REG_PIN_HI_CFG;
> + *mask = FIELD_PREP(RTL8231_PIN_HI_CFG_DIR_MASK, pin_mask);
> + } else {
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +static int rtl8231_pinctrl_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct rtl8231_pin_ctrl *ctrl;
> + struct gpio_regmap_config gpio_cfg = {};
> + struct gpio_regmap *gr;
> + int err;
> +
> + ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
> + if (!ctrl)
> + return -ENOMEM;
> +
> + ctrl->map = dev_get_regmap(dev->parent, NULL);
> + if (IS_ERR_OR_NULL(ctrl->map)) {
> + dev_err(dev, "failed to retrieve regmap\n");
> + if (!ctrl->map)
> + return -ENODEV;
> + else
> + return PTR_ERR(ctrl->map);
> + }
> +
> + err = rtl8231_pinctrl_init(dev, ctrl);
> + if (err)
> + return err;
> +
> + gpio_cfg.regmap = ctrl->map;
> + gpio_cfg.parent = dev->parent;
> + gpio_cfg.ngpio = RTL8231_NUM_GPIOS;
> + gpio_cfg.ngpio_per_reg = RTL8231_BITS_VAL;
> +
> + gpio_cfg.reg_dat_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DATA0);
> + gpio_cfg.reg_set_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DATA0);
> + gpio_cfg.reg_dir_in_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DIR0);
> + gpio_cfg.no_set_on_input = true;
> +
> + gpio_cfg.reg_mask_xlate = rtl8231_gpio_reg_mask_xlate;
> +
> + gr = devm_gpio_regmap_register(dev, &gpio_cfg);
> + if (IS_ERR(gr)) {
> + dev_err(dev, "failed to register gpio controller\n");
> + return PTR_ERR(gr);
> + }
> +
> + return 0;
> +}
> +
> +static struct platform_driver rtl8231_pinctrl_driver = {
> + .driver = {
> + .name = "rtl8231-pinctrl",
> + },
> + .probe = rtl8231_pinctrl_probe,
> +};
> +module_platform_driver(rtl8231_pinctrl_driver);
> +
> +MODULE_AUTHOR("Sander Vanheule <sander@svanheule.net>");
> +MODULE_DESCRIPTION("Realtek RTL8231 pin control and GPIO support");
> +MODULE_LICENSE("GPL v2");
> --
> 2.31.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-17 21:43 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 12:25 [PATCH 0/5] RTL8231 GPIO expander support Sander Vanheule
2021-05-11 12:25 ` [PATCH 1/5] dt-bindings: leds: Binding for RTL8231 scan matrix Sander Vanheule
2021-05-17 22:31 ` Rob Herring
2021-05-19 16:39 ` Sander Vanheule
2021-05-11 12:25 ` [PATCH 2/5] dt-bindings: mfd: Binding for RTL8231 Sander Vanheule
2021-05-17 22:38 ` Rob Herring
2021-05-19 16:53 ` Sander Vanheule
2021-05-11 12:25 ` [PATCH 3/5] mfd: Add RTL8231 core device Sander Vanheule
2021-05-12 12:29 ` kernel test robot
2021-05-12 13:13 ` kernel test robot
2021-05-19 14:58 ` Lee Jones
2021-05-19 15:11 ` Sander Vanheule
2021-05-11 12:25 ` [PATCH 4/5] pinctrl: Add RTL8231 pin control and GPIO support Sander Vanheule
2021-05-11 12:25 ` [PATCH 5/5] leds: Add support for RTL8231 LED scan matrix Sander Vanheule
[not found] ` <CAHp75VffoKyyPJbdtKMLx575c9LT0S8+EHOk7Mw36j=aTL6Q4Q@mail.gmail.com>
2021-05-16 21:40 ` [PATCH 0/5] RTL8231 GPIO expander support Sander Vanheule
2021-05-17 8:13 ` Andy Shevchenko
2021-05-17 8:50 ` Sander Vanheule
2021-05-17 19:32 ` Sander Vanheule
2021-05-17 19:28 ` [PATCH v2 0/7] " Sander Vanheule
2021-05-17 19:28 ` [PATCH v2 1/7] regmap: Add MDIO bus support Sander Vanheule
2021-05-19 16:12 ` Mark Brown
2021-05-17 19:28 ` [PATCH v2 2/7] gpio: regmap: Add configurable dir/value order Sander Vanheule
2021-05-17 21:06 ` Andy Shevchenko
2021-05-18 1:40 ` Andrew Lunn
2021-05-18 11:39 ` Sander Vanheule
2021-05-23 22:21 ` Sander Vanheule
2021-05-18 8:39 ` Michael Walle
2021-05-18 10:39 ` Andy Shevchenko
2021-05-23 21:19 ` Sander Vanheule
2021-05-17 19:28 ` [PATCH v2 3/7] dt-bindings: leds: Binding for RTL8231 scan matrix Sander Vanheule
2021-05-17 19:28 ` [PATCH v2 4/7] dt-bindings: mfd: Binding for RTL8231 Sander Vanheule
2021-05-18 22:02 ` Linus Walleij
2021-05-17 19:28 ` [PATCH v2 5/7] mfd: Add RTL8231 core device Sander Vanheule
2021-05-17 21:18 ` Andy Shevchenko
2021-05-23 21:28 ` Sander Vanheule
2021-05-24 7:49 ` Andy Shevchenko
2021-05-24 7:50 ` Sander Vanheule
2021-05-24 7:55 ` Andy Shevchenko
2021-05-24 8:04 ` Sander Vanheule
2021-05-17 19:28 ` [PATCH v2 6/7] pinctrl: Add RTL8231 pin control and GPIO support Sander Vanheule
2021-05-17 21:42 ` Andy Shevchenko [this message]
2021-05-17 21:46 ` Andy Shevchenko
2021-05-23 21:42 ` Sander Vanheule
2021-05-17 19:28 ` [PATCH v2 7/7] leds: Add support for RTL8231 LED scan matrix Sander Vanheule
2021-05-17 22:00 ` Andy Shevchenko
2021-05-23 21:53 ` Sander Vanheule
2021-05-19 16:10 ` (subset) [PATCH v2 0/7] RTL8231 GPIO expander support Mark Brown
2021-05-23 22:33 ` [PATCH v3 0/6] " Sander Vanheule
2021-05-23 22:33 ` [PATCH v3 1/6] gpio: regmap: Add quirk for output data register Sander Vanheule
2021-05-28 6:40 ` Michael Walle
2021-06-03 10:03 ` Sander Vanheule
2021-05-31 7:25 ` Bartosz Golaszewski
2021-05-23 22:34 ` [PATCH v3 2/6] dt-bindings: leds: Binding for RTL8231 scan matrix Sander Vanheule
2021-06-02 18:58 ` Rob Herring
2021-05-23 22:34 ` [PATCH v3 3/6] dt-bindings: mfd: Binding for RTL8231 Sander Vanheule
2021-05-27 23:31 ` Linus Walleij
2021-06-02 19:02 ` Rob Herring
2021-05-23 22:34 ` [PATCH v3 4/6] mfd: Add RTL8231 core device Sander Vanheule
2021-05-24 8:02 ` Andy Shevchenko
2021-05-24 8:23 ` Sander Vanheule
2021-05-24 10:18 ` Andy Shevchenko
2021-05-24 11:41 ` Sander Vanheule
2021-05-23 22:34 ` [PATCH v3 5/6] pinctrl: Add RTL8231 pin control and GPIO support Sander Vanheule
[not found] ` <CAHp75VfCCFd9SQwqv-JhdHMudYWdaa1tcVp4ZNescioWTaoXFQ@mail.gmail.com>
[not found] ` <CAHp75VceQ_Wiaf8zFN+f4uk6nv=ZmhE_rGgbEcB1hYh2Kz5VyA@mail.gmail.com>
2021-05-24 11:39 ` Sander Vanheule
2021-05-28 6:29 ` Michael Walle
2021-05-28 6:42 ` Sander Vanheule
2021-05-28 6:43 ` Michael Walle
2021-05-23 22:34 ` [PATCH v3 6/6] leds: Add support for RTL8231 LED scan matrix Sander Vanheule
2021-05-24 10:24 ` Andy Shevchenko
2021-05-24 12:04 ` Sander Vanheule
2021-05-24 12:47 ` Andy Shevchenko
2021-05-24 15:30 ` Sander Vanheule
2021-05-24 1:10 ` [PATCH v3 0/6] RTL8231 GPIO expander support Andrew Lunn
2021-05-24 7:53 ` Andy Shevchenko
2021-05-24 11:41 ` Sander Vanheule
2021-05-24 12:54 ` Andy Shevchenko
2021-05-24 15:03 ` Sander Vanheule
2021-05-24 16:30 ` Andy Shevchenko
2021-05-25 17:11 ` Andy Shevchenko
2021-05-25 18:00 ` Sander Vanheule
2021-05-26 21:02 ` Sander Vanheule
2021-05-27 10:38 ` Andy Shevchenko
2021-05-27 10:41 ` Hans de Goede
2021-05-24 15:20 ` Sander Vanheule
2021-05-28 6:37 ` Michael Walle
2021-05-30 16:19 ` Sander Vanheule
2021-05-30 16:51 ` Hans de Goede
2021-05-30 18:16 ` Andy Shevchenko
2021-05-30 21:22 ` Michael Walle
2021-05-31 8:36 ` Sander Vanheule
2021-05-31 10:02 ` Michael Walle
[not found] ` <CAHp75VfOrUBRQH1vrXEwHN4ZPojQfQju-_wp_3djZeozEaatug@mail.gmail.com>
2021-05-31 15:33 ` [PATCH 0/5] " Sander Vanheule
2021-05-31 15:48 ` Andy Shevchenko
2021-06-01 11:49 ` Michael Walle
2021-06-01 15:24 ` Andy Shevchenko
2021-06-02 20:20 ` Sander Vanheule
2021-06-01 9:59 ` [PATCH v3 0/6] " Linus Walleij
2021-06-01 10:18 ` Michael Walle
2021-06-01 10:51 ` Linus Walleij
2021-06-01 11:41 ` Michael Walle
2021-06-01 11:48 ` Linus Walleij
2021-06-03 10:00 ` [PATCH v4 0/5] " Sander Vanheule
2021-06-03 10:00 ` [PATCH v4 1/5] dt-bindings: leds: Binding for RTL8231 scan matrix Sander Vanheule
2021-06-03 10:00 ` [PATCH v4 2/5] dt-bindings: mfd: Binding for RTL8231 Sander Vanheule
2021-06-03 10:00 ` [PATCH v4 3/5] mfd: Add RTL8231 core device Sander Vanheule
2021-06-03 10:58 ` Andy Shevchenko
2021-06-03 11:28 ` Sander Vanheule
2021-06-03 14:03 ` Andrew Lunn
2021-06-03 15:20 ` Sander Vanheule
2021-06-05 11:07 ` Sander Vanheule
2021-06-03 10:00 ` [PATCH v4 4/5] pinctrl: Add RTL8231 pin control and GPIO support Sander Vanheule
2021-06-03 10:18 ` Andy Shevchenko
2021-06-03 15:58 ` kernel test robot
2021-06-04 7:00 ` Sander Vanheule
2021-06-04 22:10 ` Linus Walleij
2021-06-03 10:00 ` [PATCH v4 5/5] leds: Add support for RTL8231 LED scan matrix Sander Vanheule
2021-06-03 11:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf0Qo-hBUAOwhxGiH6azFg0OPV8OkUSfTxWet__MBF9yA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=michael@walle.cc \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).