From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37573CA9EC0 for ; Mon, 28 Oct 2019 23:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E88E4214E0 for ; Mon, 28 Oct 2019 23:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572305171; bh=q0OTmR1wgzTZD6EaP5k/W/AbGqmVSJjg13ZftmTiSZE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=BexR/5bXBWiGW3uMIItcsAats02ICrsL7UHCNSS6qUN2wF2edsQCNyV3ffDQFdJLy fpiK6MBlsimtdT6DGkspTWSV6u/24zCQlLGlv+DaW1S9CWUo5pb4aIDtwIQ/AGvj7L SVqO6t/E6MFmBeOYrD7BUNb5YDnzHz7qWiiJfILs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729867AbfJ1X0K (ORCPT ); Mon, 28 Oct 2019 19:26:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:41474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbfJ1X0K (ORCPT ); Mon, 28 Oct 2019 19:26:10 -0400 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D497321835; Mon, 28 Oct 2019 23:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572305169; bh=q0OTmR1wgzTZD6EaP5k/W/AbGqmVSJjg13ZftmTiSZE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hezMheFbDN23JCAY51dksxmJGn0f0gJFzlQ8PYwJy4eQmyUpqFhnzr863IXmnm6ZY kcB9f8rfz07kpiqgLMVBNNbp+poxaJxOovMwaRP++vNhaK++Mkx/XqdgjR5SO05Klx iC8UVKO2J1iWAez6QSVAdSSs6K5+czLaTrL27/J4= Received: by mail-qt1-f179.google.com with SMTP id x14so7020839qtq.3; Mon, 28 Oct 2019 16:26:08 -0700 (PDT) X-Gm-Message-State: APjAAAXA12PoJAjIQharsHtY33lEuNdXU5kQnmcVaGF/9Rk2mAYevXvN bsEa+1uMlI61Yl2eoqp1wRj36gmF2P68X46kvA== X-Google-Smtp-Source: APXvYqyIOnmWjP3GoLFvC7z60bp1fpcfLf2ubB7T6b3H6DBWuYxFoBuWQX2ZNarU+6b5ojoZdspaBlyJz9Lj0u5QWLs= X-Received: by 2002:aed:2706:: with SMTP id n6mr523854qtd.224.1572305168028; Mon, 28 Oct 2019 16:26:08 -0700 (PDT) MIME-Version: 1.0 References: <20190912213257.24147-1-andreas@kemnade.info> <20190912213257.24147-2-andreas@kemnade.info> In-Reply-To: <20190912213257.24147-2-andreas@kemnade.info> From: Rob Herring Date: Mon, 28 Oct 2019 18:25:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios To: Andreas Kemnade Cc: Lee Jones , Daniel Thompson , Jingoo Han , Jacek Anaszewski , Pavel Machek , Dan Murphy , Mark Rutland , Bartlomiej Zolnierkiewicz , dri-devel , Linux LED Subsystem , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux Fbdev development list Content-Type: text/plain; charset="UTF-8" Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu, Sep 12, 2019 at 4:33 PM Andreas Kemnade wrote: > > add enable-gpios to describe HWEN pin > > Signed-off-by: Andreas Kemnade > Acked-by: Daniel Thompson This breaking linux-next now... > --- > changes in v2: added example > changes in v3: added Acked-by > changes in v4: moved enable-gpios to the right position > in the example > .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > index dc129d9a329e..c8470628fe02 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml > @@ -29,6 +29,10 @@ properties: > '#size-cells': > const: 0 > > + enable-gpios: > + description: GPIO to use to enable/disable the backlight (HWEN pin). > + maxItems: 1 > + > required: > - compatible > - reg > @@ -96,6 +100,7 @@ examples: > led-controller@38 { > compatible = "ti,lm3630a"; > reg = <0x38>; > + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; Error: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dts:24.46-47 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml] Error 1 scripts/Makefile.lib:314: recipe for target 'Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml' failed You need the include for the define. Rob