Re: [PATCH 1/1] leds: lgm: Improve Kconfig help

[Rahul Tanwar <rtanwar@maxlinear.com>]

Hi Randy,

On 18/3/2021 11:02 am, Randy Dunlap wrote:
> This email was sent from outside of MaxLinear.
> 
> 
> Hi,
> 
> For the leds/blink/Kconfig file at least, something has
> changed all of the tabs to spaces.
> 
> Keywords in Kconfig files should be indented with one tab,
> while help text should be indented with one tab + 2 spaces.
>


Hmm, facing some IT issues with git send-email so i had to send it by 
other means. I will fix it in V1 by ensuring that i send using git.


> 
> On 3/17/21 3:04 AM, Rahul Tanwar wrote:
>> Remove unnecessary Kconfig symbol LEDS_BLINK
>> Improve Kconfig help text to make it more useful.
>>
>> Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
>> ---
>>
>> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
>> index 6dedc58c47b3..2de2973fbc6b 100644
>> --- a/drivers/leds/blink/Kconfig
>> +++ b/drivers/leds/blink/Kconfig
>> @@ -1,21 +1,19 @@
>> -menuconfig LEDS_BLINK
>> -       bool "LED Blink support"
>> -       depends on LEDS_CLASS
>> -       help
>> -         This option enables blink support for the leds class.
>> -         If unsure, say Y.
>> -
>> -if LEDS_BLINK
>> -
>> -config LEDS_BLINK_LGM
>> -       tristate "LED support for Intel LGM SoC series"
>> +config LEDS_LGM
>> +       tristate "LED support for LGM SoC series"
>>           depends on GPIOLIB
>>           depends on LEDS_CLASS
>>           depends on MFD_SYSCON
>>           depends on OF
>>           help
>> -         Parallel to serial conversion, which is also called SSO
>> controller,
>> -         can drive external shift register for LED outputs.
>> -         This enables LED support for Serial Shift Output controller(SSO).
>> +         This option enables support for LEDs connected to GPIO lines on
>> +         Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial
> 
>                        Mountain (LGM)
> 
>> +         Shift Output(SSO) controller. The driver supports hardware
> 
>                    Output (SSO)
> 
>> +         blinking with a configurable LED update/blink frequency in two
>> +         modes, 2/4/8/10 Hz in low speed mode and 50/100/200/250 KHz in
>> +         high speed mode. The LEDs can be configured to be triggered by
>> +         SW/CPU or by hardware. Say 'Y' here if you are working on LGM
> 
> Please spell out "software".
> 
>> +         SoC based platform.
>> +
>> +         To compile this driver as a module, choose M here: the
>> +         module will be called leds-lgm-sso.
>>
>> -endif # LEDS_BLINK
> 

Well noted about above improvements suggestions. Shall update in V1. Thanks.

Regards,
Rahul

> thanks.
> --
> ~Randy
> 
>