Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] leds: lgm: fix gpiolib dependency
       [not found] ` <MN2PR19MB3693FBBD3E6DB8A916260D69B16C9@MN2PR19MB3693.namprd19.prod.outlook.com>
@ 2021-03-15 11:12   ` Pavel Machek
  0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2021-03-15 11:12 UTC (permalink / raw)
  To: Rahul Tanwar
  Cc: Arnd Bergmann, arnd, dmurphy, linux-leds, linux-kernel,
	Cheol Yong Kim, Qiming Wu


[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Hi!

> On 15/3/2021 5:44 pm, Rahul Tanwar wrote:
> 
> From: Arnd Bergmann <arnd@kernel.org><mailto:arnd@kernel.org>
> 
> From: Arnd Bergmann <arnd@arndb.de><mailto:arnd@arndb.de>
> 
...

> 
> diff<https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#iZ30drivers:leds:blink:Kconfig> --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 265b53476a80..6dedc58c47b3 100644

...
> 
> Acked-by: Rahul Tanwar <rtanwar@maxlinear.com><mailto:rtanwar@maxlinear.com>

You may want to do something with your mail configuration. This is
quite corrupted.

								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] leds: lgm: fix gpiolib dependency
       [not found] <MN2PR19MB36933AFDC4531D0F7A984608B16C9@MN2PR19MB3693.namprd19.prod.outlook.com>
       [not found] ` <MN2PR19MB3693FBBD3E6DB8A916260D69B16C9@MN2PR19MB3693.namprd19.prod.outlook.com>
@ 2021-03-16  8:56 ` Rahul Tanwar
  1 sibling, 0 replies; 3+ messages in thread
From: Rahul Tanwar @ 2021-03-16  8:56 UTC (permalink / raw)
  To: Arnd Bergmann, Pavel Machek
  Cc: Dan Murphy, linux-leds, linux-kernel, Cheol Yong Kim, Qiming Wu

On 15/3/2021 5:44 pm, Rahul Tanwar wrote:
> From: Arnd Bergmann<arnd@kernel.org>
> To: Pavel Machek<pavel@ucw.cz>,
> 	Amireddy Mallikarjuna reddy
> 	<mallikarjunax.reddy@linux.intel.com>
> Cc: Arnd Bergmann<arnd@arndb.de>, Dan Murphy<dmurphy@ti.com>,
> 	linux-leds@vger.kernel.org,linux-kernel@vger.kernel.org
> Subject:[PATCH] leds: lgm: fix gpiolib dependency  <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#r>
> Date: Mon,  8 Mar 2021 16:30:46 +0100
> Message-ID:<20210308153052.2353885-1-arnd@kernel.org>  (raw  <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/raw>)
> 
> From: Arnd Bergmann<arnd@arndb.de>
> 
> Without gpiolib, the driver fails to build:
> 
>      drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
>              struct gpio_chip chip;
>                               ^
>      include/linux/gpio.h:107:8: note: forward declaration of 'struct gpio_chip'
>      struct gpio_chip;
>             ^
>      drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
>                      gpiod_set_value(led->gpiod, val);
>                      ^
>      drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean 'gpio_set_value'?
>      include/linux/gpio.h:168:20: note: 'gpio_set_value' declared here
>      static inline void gpio_set_value(unsigned gpio, int value)
>                         ^
>      drivers/leds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
>                      gpiod_set_value(led->gpiod, 1);
>                      ^
> 
> Add the dependency in Kconfig.
> 
> Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
> ---
>   drivers/leds/blink/Kconfig  <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#Z30drivers:leds:blink:Kconfig>  | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff 
> <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#iZ30drivers:leds:blink:Kconfig> 
> --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig index 
> 265b53476a80..6dedc58c47b3 100644 --- a/drivers/leds/blink/Kconfig +++ 
> b/drivers/leds/blink/Kconfig @@ -9,6 +9,7 @@ if LEDS_BLINK   
>   config LEDS_BLINK_LGM
>   	tristate "LED support for Intel LGM SoC series"
> + depends on GPIOLIB   	depends on LEDS_CLASS
>   	depends on MFD_SYSCON
>   	depends on OF
> -- 
> 2.29.2
> 

Acked-by: Rahul Tanwar <rtanwar@maxlinear.com>





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] leds: lgm: fix gpiolib dependency
@ 2021-03-08 15:30 Arnd Bergmann
  0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-03-08 15:30 UTC (permalink / raw)
  To: Pavel Machek, Amireddy Mallikarjuna reddy
  Cc: Arnd Bergmann, Dan Murphy, linux-leds, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Without gpiolib, the driver fails to build:

    drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
            struct gpio_chip chip;
                             ^
    include/linux/gpio.h:107:8: note: forward declaration of 'struct gpio_chip'
    struct gpio_chip;
           ^
    drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
                    gpiod_set_value(led->gpiod, val);
                    ^
    drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean 'gpio_set_value'?
    include/linux/gpio.h:168:20: note: 'gpio_set_value' declared here
    static inline void gpio_set_value(unsigned gpio, int value)
                       ^
    drivers/leds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
                    gpiod_set_value(led->gpiod, 1);
                    ^

Add the dependency in Kconfig.

Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/leds/blink/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 265b53476a80..6dedc58c47b3 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -9,6 +9,7 @@ if LEDS_BLINK
 
 config LEDS_BLINK_LGM
 	tristate "LED support for Intel LGM SoC series"
+	depends on GPIOLIB
 	depends on LEDS_CLASS
 	depends on MFD_SYSCON
 	depends on OF
-- 
2.29.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <MN2PR19MB36933AFDC4531D0F7A984608B16C9@MN2PR19MB3693.namprd19.prod.outlook.com>
     [not found] ` <MN2PR19MB3693FBBD3E6DB8A916260D69B16C9@MN2PR19MB3693.namprd19.prod.outlook.com>
2021-03-15 11:12   ` [PATCH] leds: lgm: fix gpiolib dependency Pavel Machek
2021-03-16  8:56 ` Rahul Tanwar
2021-03-08 15:30 Arnd Bergmann

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git