From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sven Schuchmann <schuchmann@schleissheimer.de>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT
Date: Fri, 19 Feb 2021 16:50:56 +0200 [thread overview]
Message-ID: <YC/QUIc4LOJtyY5r@smile.fi.intel.com> (raw)
In-Reply-To: <DB8P190MB063470370E6CD67900726B5DD9849@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
On Fri, Feb 19, 2021 at 02:09:03PM +0000, Sven Schuchmann wrote:
> > Von: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Gesendet: Freitag, 19. Februar 2021 14:56
> > > > > > Can you or Dan submit patch getting the regulator support to work? If
> > > > > > not, I guess we should remove the regulator support after all.
> > > > >
> > > > > To be true I am fairly new to the kernel and have no idea
> > > > > how to test this. So no, I don't want provide a patch (except
> > > > > for removing), sorry.
> > > >
> > > > No problem. It seems Andy submitted series for this.
> > > >
> > >
> > > To me it seems that patches from Andy don't make
> > > the regulator work. Maybe I am wrong?
> >
> > I;m not sure I understand this correctly. Do you mean that my patches broke
> > something? Which one explicitly and what is broken?
>
> No, your patches do not break something (as far as I can see).
> Pavel asked for a patch to fix the regulator. The regulator
> at this time is only initialized but never used in the lp50xx.
> I told him (see above) that I cannot provide a patch which
> fixes this. He answered that you fixed this in your series,
> but to me it doesn't seem so.
> or did you fix the regulator usage in your patch series?
No, I haven't touched regulator and I see now what is there.
One may add some code, I know Linus did it in many places, maybe he can help to
have done this properly?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-19 14:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 14:37 [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT Sven Schuchmann
2021-02-04 14:53 ` Pavel Machek
2021-02-05 9:59 ` AW: " Sven Schuchmann
2021-02-05 10:34 ` Pavel Machek
2021-02-05 11:21 ` AW: " Sven Schuchmann
2021-02-19 11:16 ` Pavel Machek
2021-02-19 11:38 ` AW: " Sven Schuchmann
2021-02-19 13:55 ` Andy Shevchenko
2021-02-19 14:09 ` AW: " Sven Schuchmann
2021-02-19 14:50 ` Andy Shevchenko [this message]
2021-02-19 14:18 ` Andy Shevchenko
2021-02-19 18:07 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC/QUIc4LOJtyY5r@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmurphy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=schuchmann@schleissheimer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).