From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22DB9C433B4 for ; Mon, 12 Apr 2021 11:25:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DADA561244 for ; Mon, 12 Apr 2021 11:25:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238974AbhDLL0D (ORCPT ); Mon, 12 Apr 2021 07:26:03 -0400 Received: from mga09.intel.com ([134.134.136.24]:6805 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237626AbhDLL0C (ORCPT ); Mon, 12 Apr 2021 07:26:02 -0400 IronPort-SDR: i73jeRZSnCaVIgLuFgCos4tDrB0iuZHH6XstpoV2MqYeuTLDB8DiKoO0avwSnMc7rKv5sCGK9b cl/CLiNDPvLg== X-IronPort-AV: E=McAfee;i="6000,8403,9951"; a="194281033" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="194281033" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 04:25:42 -0700 IronPort-SDR: niJ3U8khfc0yIwNri7iVLFqzyHDmHD0X/RThzsc6BfIhm5vA9AHoCvUHYrKR2zkmYLJ0f9LwOV PVmvsIJSaFZQ== X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="398328527" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 04:25:41 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lVuhG-003RFi-Jv; Mon, 12 Apr 2021 14:25:38 +0300 Date: Mon, 12 Apr 2021 14:25:38 +0300 From: Andy Shevchenko To: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sakari Ailus , Pavel Machek Subject: Re: [PATCH v1 1/1] leds: as3645a: Keep fwnode reference count balanced Message-ID: References: <20210412103838.2055499-1-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210412103838.2055499-1-andy.shevchenko@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, Apr 12, 2021 at 01:38:38PM +0300, Andy Shevchenko wrote: > The commit 88b7e9ffe594 ("leds: as3645a: Switch to fwnode property API") > missed the point that loop counter should be put after use. Otherwise > the reference count of it will become unbalanced. Scratch this, I might be not slept enough. -- With Best Regards, Andy Shevchenko