From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4377EC433ED for ; Sat, 1 May 2021 06:24:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 001E0613ED for ; Sat, 1 May 2021 06:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbhEAGZM (ORCPT ); Sat, 1 May 2021 02:25:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:46940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhEAGZM (ORCPT ); Sat, 1 May 2021 02:25:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F033D613C2; Sat, 1 May 2021 06:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619850261; bh=X9cYeVXcga7kObVA/p1U0zrIolbkSZQkyIvB3ZJbuEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vvKskF8A3MqcJvyaMlaBzRiSpwXUFgxqqJHthqQW9syCx4jeqsxXZHSR1s7Lbyw4E 3wPyrmR6mxInIoxNzLFq+tNhN931Q2HKNpucp9/6KjWh2+M+2IKcnJ5MVnKZseGzHY rENlfN6cHDZgqqutaby3B12wsgoThhqjMiCCfzPs= Date: Sat, 1 May 2021 08:24:16 +0200 From: Greg Kroah-Hartman To: Enzo Matsumiya Cc: linux-leds@vger.kernel.org, linux-block@vger.kernel.org, u.kleine-koenig@pengutronix.de, Jens Axboe , Pavel Machek , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/2] block: export block_class and disk_type symbols Message-ID: References: <20210430183216.27458-1-ematsumiya@suse.de> <20210430183216.27458-2-ematsumiya@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210430183216.27458-2-ematsumiya@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Apr 30, 2021 at 03:32:10PM -0300, Enzo Matsumiya wrote: > Export symbols to be used by _for_each_blk() helper in LED block > trigger. > > Signed-off-by: Enzo Matsumiya > --- > block/genhd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/genhd.c b/block/genhd.c > index 8c8f543572e6..516495179230 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -1218,6 +1218,7 @@ static void disk_release(struct device *dev) > struct class block_class = { > .name = "block", > }; > +EXPORT_SYMBOL(block_class); > > static char *block_devnode(struct device *dev, umode_t *mode, > kuid_t *uid, kgid_t *gid) > @@ -1235,6 +1236,7 @@ const struct device_type disk_type = { > .release = disk_release, > .devnode = block_devnode, > }; > +EXPORT_SYMBOL(disk_type); > > #ifdef CONFIG_PROC_FS > /* Please please no. These should not be needed by anything. And if they really do, they must be EXPORT_SYMBOL_GPL(). thanks, greg k-h