From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF317C433ED for ; Thu, 13 May 2021 15:25:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 958E9613C5 for ; Thu, 13 May 2021 15:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234839AbhEMP1B (ORCPT ); Thu, 13 May 2021 11:27:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:40308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234885AbhEMP0r (ORCPT ); Thu, 13 May 2021 11:26:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 28E59613BF; Thu, 13 May 2021 15:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620919537; bh=foFE/3HGOiVwbmdkUBxDhc/bQzdfVzKQdZ5U+jRRBo8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zC2/654ihZIAJmLWlcLGHhhZ1b6DjiC8KyZKalOZoHGWeOHN1usLxRYd0FgnT6NFW Bqeu9qM5BTIBTrnMs6O2Nr6bQE1DHG1chhKWnUrz2uXLjs/zvaaCB22q1zYAvpPgip mCpf65HjypoCRbOdvInt/3AoLEznLv6cr0ebivb0= Date: Thu, 13 May 2021 17:25:35 +0200 From: Greg Kroah-Hartman To: Jacek Anaszewski Cc: linux-kernel@vger.kernel.org, Phillip Potter , stable , Linux LED Subsystem , Pavel Machek Subject: Re: [PATCH 09/69] leds: lp5523: check return value of lp5xx_read and jump to cleanup code Message-ID: References: <20210503115736.2104747-1-gregkh@linuxfoundation.org> <20210503115736.2104747-10-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, May 03, 2021 at 09:36:14PM +0200, Jacek Anaszewski wrote: > On 5/3/21 1:56 PM, Greg Kroah-Hartman wrote: > > From: Phillip Potter > > > > Check return value of lp5xx_read and if non-zero, jump to code at end of > > the function, causing lp5523_stop_all_engines to be executed before > > returning the error value up the call chain. This fixes the original > > commit (248b57015f35) which was reverted due to the University of Minnesota > > problems. > > > > Cc: Jacek Anaszewski > > Cc: stable > > Signed-off-by: Phillip Potter > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/leds/leds-lp5523.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c > > index 5036d7d5f3d4..b1590cb4a188 100644 > > --- a/drivers/leds/leds-lp5523.c > > +++ b/drivers/leds/leds-lp5523.c > > @@ -305,7 +305,9 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip) > > /* Let the programs run for couple of ms and check the engine status */ > > usleep_range(3000, 6000); > > - lp55xx_read(chip, LP5523_REG_STATUS, &status); > > + ret = lp55xx_read(chip, LP5523_REG_STATUS, &status); > > + if (ret) > > + goto out; > > status &= LP5523_ENG_STATUS_MASK; > > if (status != LP5523_ENG_STATUS_MASK) { > > > > Acked-by: Jacek Anaszewski Thanks for the review!