From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_ADSP_NXDOMAIN, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD996C47082 for ; Sat, 5 Jun 2021 10:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F04F613AA for ; Sat, 5 Jun 2021 10:02:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbhFEKEF (ORCPT ); Sat, 5 Jun 2021 06:04:05 -0400 Received: from fgw22-7.mail.saunalahti.fi ([62.142.5.83]:45747 "EHLO fgw22-7.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229892AbhFEKEE (ORCPT ); Sat, 5 Jun 2021 06:04:04 -0400 X-Greylist: delayed 962 seconds by postgrey-1.27 at vger.kernel.org; Sat, 05 Jun 2021 06:04:03 EDT Received: from localhost (88-115-248-186.elisa-laajakaista.fi [88.115.248.186]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id dc745646-c5e2-11eb-88cb-005056bdf889; Sat, 05 Jun 2021 12:46:12 +0300 (EEST) Date: Sat, 5 Jun 2021 12:46:11 +0300 From: andy@surfacebook.localdomain To: Linus Walleij Cc: Andy Shevchenko , Pavel Machek , Amireddy Mallikarjuna reddy , Abanoub Sameh , Marek =?iso-8859-1?Q?Beh=FAn?= , Krzysztof Kozlowski , Linux LED Subsystem , linux-kernel Subject: Re: [PATCH v2 12/13] leds: rt8515: Put fwnode in any case during ->probe() Message-ID: References: <20210529111935.3849707-1-andy.shevchenko@gmail.com> <20210529111935.3849707-12-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Tue, Jun 01, 2021 at 12:06:05PM +0200, Linus Walleij kirjoitti: > On Sat, May 29, 2021 at 1:19 PM Andy Shevchenko > wrote: > > > fwnode_get_next_available_child_node() bumps a reference counting of > > a returned variable. We have to balance it whenever we return to > > the caller. > > > > Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver") > > Cc: Linus Walleij > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Linus Walleij Thanks! Pavel, can you, please, review this batch? I think I addressed most of your comments if not all. -- With Best Regards, Andy Shevchenko