From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 437EBC433FE for ; Wed, 8 Sep 2021 17:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2082D61157 for ; Wed, 8 Sep 2021 17:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350158AbhIHRLe (ORCPT ); Wed, 8 Sep 2021 13:11:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233140AbhIHRLd (ORCPT ); Wed, 8 Sep 2021 13:11:33 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2AD1C06175F for ; Wed, 8 Sep 2021 10:10:25 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id c42-20020a05683034aa00b0051f4b99c40cso3920493otu.0 for ; Wed, 08 Sep 2021 10:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6LGhLlyGfDieC90krK66I/Mdf34zEcB4tJ81qPREmoM=; b=c80CLUoDExwws380FL+IbjjQl1U/Fmd7uo4QCdYXq8THT//hiA5ubYgIx3oVA8uv17 1UbavbcuMaE3fhu9iiLkOVDoHTYqlw6AllaFRb+gLvdKshd/L3D91qvCLdgj7sjHVZdS /cEyQTBgIulkYolYrZ6wcrK/U9PFPHKR3kmta6XzWFopeO5dYQK+vVgQoPjrctKskzlR AlI256UVnHU04mZMt4e2Hb/opWWWN7OVfI58PYzxJV8khac9vtAm9PJMt4Kvo6owlhag 2ekYSEYUZRz2iOL/YR/BXfFXlL568R/Knw/nXb3aRGoEZWojF/3wwR0lJWmxfcdoRke0 gwzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6LGhLlyGfDieC90krK66I/Mdf34zEcB4tJ81qPREmoM=; b=GqlI9P752dvvjUC5EP1OmrEFyzAQop+Mr+o8/SY5gT5kyieWmzG03V+sU7VM+dcrxd MTVwxo76AedCb4Fm+ZU/M0vGqOiR8meiZAhA2gDQQ7mcObh3ZcC9DZ5h0slW5LATOMLk OXc/h7nJIkOehOH+EB/3wbz7zQRb8aw0f4qjEDuJ7FU+IYKRnODBENxy7dwtwUHmdtHi KPloVtZFWgPGv/UbYhWSXAnSt596apXFGfMIXX6LjicCIBTFjJnPTRMNTqrogzDHZDam wz+0ur5I5/MRFW9DzqWj8tjp95zK/1xGgjdtgiF9A2DSbvWFeId9vfE6jWpNBlPQ+1fW MI7w== X-Gm-Message-State: AOAM5304L0Z8ZHkumt6kyWY75Yfhd55PlZSqJ0jzP7PbMlTU6ba9m2Hp f87DlL4h8OCUl/n2lKaL9OewJw== X-Google-Smtp-Source: ABdhPJx4UnBs7ICh/RDtbZT+vcUobyCQZkVlqESgpps4CBsDWRckLDEI0l1Y/YgUWM/au1q0GH4B4A== X-Received: by 2002:a05:6830:3114:: with SMTP id b20mr4149958ots.17.1631121025099; Wed, 08 Sep 2021 10:10:25 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z78sm551229ooa.29.2021.09.08.10.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 10:10:24 -0700 (PDT) Date: Wed, 8 Sep 2021 10:11:23 -0700 From: Bjorn Andersson To: skakit@codeaurora.org Cc: Stephen Boyd , Andy Gross , Pavel Machek , Rob Herring , mka@chromium.org, kgunda@codeaurora.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/3] leds: Add pm8350c support to Qualcomm LPG driver Message-ID: References: <1630924867-4663-1-git-send-email-skakit@codeaurora.org> <1630924867-4663-3-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed 08 Sep 02:17 PDT 2021, skakit@codeaurora.org wrote: > On 2021-09-08 01:50, Stephen Boyd wrote: > > Quoting satya priya (2021-09-06 03:41:06) > > > Add pm8350c compatible and lpg_data to the driver. > > > > > > Signed-off-by: satya priya > > > --- > > > drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/drivers/leds/rgb/leds-qcom-lpg.c > > > b/drivers/leds/rgb/leds-qcom-lpg.c > > > index 327e81a..6ee80d6 100644 > > > --- a/drivers/leds/rgb/leds-qcom-lpg.c > > > +++ b/drivers/leds/rgb/leds-qcom-lpg.c > > > @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data > > > = { > > > }, > > > }; > > > > > > +static const struct lpg_data pm8350c_pwm_data = { > > > + .pwm_9bit_mask = BIT(2), > > > + > > > + .num_channels = 1, > > > + .channels = (struct lpg_channel_data[]) { > > > > Can this be const struct lpg_channel_data? I think that will move it to > > rodata which is only a good thing. > > > > I agree. > @Bjorn, can we make it const struct? > I like it and have updated the driver patches accordingly. Seems like I still have a couple of more comments from Uwe left to resolve on v9 of the driver, I'll fix those up and post the driver again. Thanks, Bjorn > > > + { .base = 0xeb00 }, > > > + }, > > > +}; > > > + > > > static const struct of_device_id lpg_of_table[] = { > > > { .compatible = "qcom,pm8150b-lpg", .data = > > > &pm8150b_lpg_data }, > > > { .compatible = "qcom,pm8150l-lpg", .data = > > > &pm8150l_lpg_data }, > > > + { .compatible = "qcom,pm8350c-pwm", .data = > > > &pm8350c_pwm_data }, > > > { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data }, > > > { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data }, > > > { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },