From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables
Date: Thu, 1 Jun 2023 19:47:09 +0300 [thread overview]
Message-ID: <ZHjLjU7WPv2W9SuJ@smile.fi.intel.com> (raw)
In-Reply-To: <20230530171100.75e5b86c@md1za8fc.ad001.siemens.net>
On Tue, May 30, 2023 at 05:11:00PM +0200, Henning Schild wrote:
> Am Sat, 27 May 2023 11:54:08 +0300
> schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>
> > On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote:
> > > The entries do not seem to be stricly needed when the number of
> > > entries is given via the number of LEDs. But adding them is a
> > > safeguard should anyone ever iterate over the tables to their end,
> > > it also gets us in line with other drivers that register
> > > "leds-gpio" tables.
> >
> > Reported-by?
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> I think we could do
>
> Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> on merge. But i would not want to send the whole series again for that
> one line.
Since you added it, `b4` will happily take it, I believe no manual work even
needed for that, thank you!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-01 16:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:46 [PATCH v4 0/4] leds: simatic-ipc-leds-gpio: split up Henning Schild
2023-05-24 12:46 ` [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables Henning Schild
2023-05-27 8:54 ` Andy Shevchenko
2023-05-30 15:11 ` Henning Schild
2023-06-01 16:47 ` Andy Shevchenko [this message]
2023-06-08 17:30 ` Lee Jones
2023-06-09 14:25 ` Andy Shevchenko
2023-06-12 11:27 ` Lee Jones
2023-06-12 11:29 ` Lee Jones
2023-06-08 17:25 ` Lee Jones
2023-05-24 12:46 ` [PATCH v4 2/4] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table Henning Schild
2023-06-08 17:26 ` Lee Jones
2023-05-24 12:46 ` [PATCH v4 3/4] leds: simatic-ipc-leds-gpio: split up into multiple drivers Henning Schild
2023-06-08 17:27 ` Lee Jones
2023-05-24 12:46 ` [PATCH v4 4/4] leds: simatic-ipc-leds-gpio: introduce more Kconfig switches Henning Schild
2023-06-08 17:28 ` Lee Jones
2023-05-25 10:11 ` [PATCH v4 0/4] leds: simatic-ipc-leds-gpio: split up Hans de Goede
2023-05-27 8:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHjLjU7WPv2W9SuJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).