From: Dan Murphy <dmurphy@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Cc: <linux-leds@vger.kernel.org>,
Vincent Donnefort <vdonnefort@gmail.com>,
Simon Guinot <simon.guinot@sequanux.org>
Subject: Re: [PATCH 1/2 v2] leds: ns2: Absorb platform data
Date: Wed, 12 Feb 2020 07:27:05 -0600 [thread overview]
Message-ID: <a7e4fefe-103c-7161-ef35-f7a0f8cb1453@ti.com> (raw)
In-Reply-To: <20200210101354.287045-1-linus.walleij@linaro.org>
Linus
On 2/10/20 4:13 AM, Linus Walleij wrote:
> Nothing in the kernel includes the external header
> <linux/platform_data/leds-kirkwood-ns2.h> so just push the
> contents into the ns2 leds driver. If someone wants to use
> platform data or board files to describe this device they
> should be able to do so using GPIO machine descriptors but
> in any case device tree should be the way forward for these
> systems in all cases I can think of, and the driver already
> supports that.
>
> Cc: Vincent Donnefort <vdonnefort@gmail.com>
> Tested-by: Simon Guinot <simon.guinot@sequanux.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Collect Simon's Tested-by tag
> ---
> drivers/leds/leds-ns2.c | 30 +++++++++++++--
> .../linux/platform_data/leds-kirkwood-ns2.h | 38 -------------------
> 2 files changed, 27 insertions(+), 41 deletions(-)
> delete mode 100644 include/linux/platform_data/leds-kirkwood-ns2.h
>
> diff --git a/drivers/leds/leds-ns2.c b/drivers/leds/leds-ns2.c
> index 7c500dfdcfa3..6d37dda12c39 100644
> --- a/drivers/leds/leds-ns2.c
> +++ b/drivers/leds/leds-ns2.c
> @@ -12,14 +12,38 @@
> #include <linux/kernel.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/leds.h>
> #include <linux/module.h>
> -#include <linux/platform_data/leds-kirkwood-ns2.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include "leds.h"
These header file change for gpio seem to belong in patch 2/2.
I don't see any gpio related changes in this patch
Dan
next prev parent reply other threads:[~2020-02-12 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 10:13 [PATCH 1/2 v2] leds: ns2: Absorb platform data Linus Walleij
2020-02-10 10:13 ` [PATCH 2/2 v2] leds: ns2: Convert to GPIO descriptors Linus Walleij
2020-02-12 13:27 ` Dan Murphy [this message]
2020-02-26 13:50 ` [PATCH 1/2 v2] leds: ns2: Absorb platform data Pavel Machek
2020-02-27 20:28 ` Dan Murphy
2020-02-28 9:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7e4fefe-103c-7161-ef35-f7a0f8cb1453@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=simon.guinot@sequanux.org \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).