From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB30C47404 for ; Wed, 9 Oct 2019 18:14:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79D8820679 for ; Wed, 9 Oct 2019 18:14:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TQg4CvEZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730256AbfJISO1 (ORCPT ); Wed, 9 Oct 2019 14:14:27 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:52253 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728804AbfJISO0 (ORCPT ); Wed, 9 Oct 2019 14:14:26 -0400 Received: by mail-wm1-f67.google.com with SMTP id r19so3660474wmh.2; Wed, 09 Oct 2019 11:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uwzBHKz4v3Z12UE7ITamse/W27iE2qROZBMwpCna8+I=; b=TQg4CvEZZVlJ92O4V6RkOXLsC97CxCbaPV8ZJ+/KkQg8DLcep8yniSWCPMn5R0GT/0 G8SAzDAZswcB5C/gf5aqU36V9UxhJXd4gMwnsLZ1n6AUx3drPcyf1IauOd0Vi8yrY/Lf CS5Bcgf/w1fa39JCfFatIa41jELs9dbo0CSFoRdqW3ypRmelp19Tiue5M0kNKY0mbh9u 3IjQqS97IAqq2ZcqwA4XQOMQzTtY9FJUZ2OhBGCskKbgGixYwNkObYldDi2kGQ7cIoD9 8+wA+CaAfyCAQbIjP2lfkzS95OqwICZukxGq2rZxzc3oIybA+ng4mj5Q2Ji55lDDnwr7 zxGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=uwzBHKz4v3Z12UE7ITamse/W27iE2qROZBMwpCna8+I=; b=AO2gfIJJvKVDKtyaQOwgVUkpq7WRURXsZemql+pwseBFxpq7kuKs8SykwVh451A1ng +eW5FEY0FyvS8ViIRBlak1qHSQ7Sg02azAbXVG0MCDk7tmB5OujQuKkMV7+pIbg38pXR IehDRGGG4GlTUelcgScVOjSQO9+WfLv5fJSVrHP+llnJtUa8BYUMLqy2iEDbRbZik+Yv 9gIuCkEm3seYKsXUD23Fe1SO12N0iVuQJikHTsbYspa3E3yO7kK525knXDPlXp3qdq3A rrygRuyBgqkQJWTTYnRPbIpPcBkTdMKny/JSqumxG+fWeKiyWgJXO4jGTZUhlyhYiqai s7xQ== X-Gm-Message-State: APjAAAU8rsGZtvc39yRH3ThN/8/D9P/nJ+P0TLFgzcnrTA9T4hpgvjSa h/Fk9u5ybwc6djJSfBwzDcU= X-Google-Smtp-Source: APXvYqwFlj9Ae6VTTr7Bijua5iLGfNtM0Tf23oRNto22SP+bCS6Toy3676uu3fROs/ojM6x+pST/TQ== X-Received: by 2002:a1c:8148:: with SMTP id c69mr3870039wmd.41.1570644863779; Wed, 09 Oct 2019 11:14:23 -0700 (PDT) Received: from [192.168.1.19] (cjk130.neoplus.adsl.tpnet.pl. [83.31.60.130]) by smtp.gmail.com with ESMTPSA id t13sm5913351wra.70.2019.10.09.11.14.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Oct 2019 11:14:23 -0700 (PDT) Subject: Re: [PATCH] leds: gpio: support multi-level brightness To: Akinobu Mita Cc: Linux LED Subsystem , linux-gpio@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , Pavel Machek , Dan Murphy References: <1570203299-4270-1-git-send-email-akinobu.mita@gmail.com> <96ac332f-359f-531a-7890-45b39e168b82@gmail.com> <7d451092-bf8a-e1d4-996c-8af3cc816fc7@gmail.com> <72129a38-d975-74d4-269d-6269556d7aae@gmail.com> From: Jacek Anaszewski Openpgp: preference=signencrypt Autocrypt: addr=jacek.anaszewski@gmail.com; prefer-encrypt=mutual; keydata= mQINBFWjfaEBEADd66EQbd6yd8YjG0kbEDT2QIkx8C7BqMXR8AdmA1OMApbfSvEZFT1D/ECR eWFBS8XtApKQx1xAs1j5z70k3zebk2eeNs5ahxi6vM4Qh89vBM46biSKeeX5fLcv7asmGb/a FnHPAfQaKFyG/Bj9V+//ef67hpjJWR3s74C6LZCFLcbZM0z/wTH+baA5Jwcnqr4h/ygosvhP X3gkRzJLSFYekmEv+WHieeKXLrJdsUPUvPJTZtvi3ELUxHNOZwX2oRJStWpmL2QGMwPokRNQ 29GvnueQdQrIl2ylhul6TSrClMrKZqOajDFng7TLgvNfyVZE8WQwmrkTrdzBLfu3kScjE14Q Volq8OtQpTsw5570D4plVKh2ahlhrwXdneSot0STk9Dh1grEB/Jfw8dknvqkdjALUrrM45eF FM4FSMxIlNV8WxueHDss9vXRbCUxzGw37Ck9JWYo0EpcpcvwPf33yntYCbnt+RQRjv7vy3w5 osVwRR4hpbL/fWt1AnZ+RvbP4kYSptOCPQ+Pp1tCw16BOaPjtlqSTcrlD2fo2IbaB5D21SUa IsdZ/XkD+V2S9jCrN1yyK2iKgxtDoUkWiqlfRgH2Ep1tZtb4NLF/S0oCr7rNLO7WbqLZQh1q ShfZR16h7YW//1/NFwnyCVaG1CP/L/io719dPWgEd/sVSKT2TwARAQABtC1KYWNlayBBbmFz emV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT6JAlgEEwEIAEICGwMHCwkIBwMC AQYVCAIJCgsDFgIBAh4BAheABQkJZgNMFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAl05/9sC GQEACgkQvWpQHLeLfCarMQ/9FN/WqJdN2tf6xkP0RFyS4ft0sT04zkOCFfOMxs8mZ+KZoMU+ X3a+fEppDL7xgRFpHyGaEel7lSi1eqtzsqZ5JiHbDS1Ht1G8TtATb8q8id68qeSeW2mfzaLQ 98NPELGfUXFoUqUQkG5z2p92UrGF4Muj1vOIW93pwvE4uDpNsl+jriwHomLtjIUoZtIRjGfZ RCyUQI0vi5LYzXCebuzAjGD7Jh2YAp7fDGrv3qTq8sX+DUJ4H/+I8PiL+jXKkEeppqIhlBJJ l4WcgggMu3c2uljYDuqRYghte33BXyCPAocfO2/sN+yJRUTVuRFlOxUk4srz/W8SQDwOAwtK V7TzdyF1/jOGBxWwS13EjMb4u3XwPMzcPlEQNdIqz76NFmJ99xYEvgkAmFmRioxuBTRv8Fs1 c1jQ00WWJ5vezqY6lccdDroPalXWeFzfPjIhKbV3LAYTlqv0It75GW9+0TBhPqdTM15DrCVX B7Ues7UnD5FBtWwewTnwr+cu8te449VDMzN2I+a9YKJ1s6uZmzh5HnuKn6tAfGyQh8MujSOM lZrNHrRsIsLXOjeGVa84Qk/watEcOoyQ7d+YaVosU0OCZl0GldvbGp1z2u8cd2N/HJ7dAgFh Q7dtGXmdXpt2WKQvTvQXhIrCWVQErNYbDZDD2V0TZtlPBaZP4fkUDkvH+Sy5Ag0EVaN9oQEQ AMPNymBNoCWc13U6qOztXrIKBVsLGZXq/yOaR2n7gFbFACD0TU7XuH2UcnwvNR+uQFwSrRqa EczX2V6iIy2CITXKg5Yvg12yn09gTmafuoIyKoU16XvC3aZQQ2Bn3LO2sRP0j/NuMD9GlO37 pHCVRpI2DPxFE39TMm1PLbHnDG8+lZql+dpNwWw8dDaRgyXx2Le542CcTBT52VCeeWDtqd2M wOr4LioYlfGfAqmwcwucBdTEBUxklQaOR3VbJQx6ntI2oDOBlNGvjnVDzZe+iREd5l40l+Oj TaiWvBGXkv6OI+wx5TFPp+BM6ATU+6UzFRTUWbj+LqVA/JMqYHQp04Y4H5GtjbHCa8abRvBw IKEvpwTyWZlfXPtp8gRlNmxYn6gQlTyEZAWodXwE7CE+KxNnq7bPHeLvrSn8bLNK682PoTGr 0Y00bguYLfyvEwuDYek1/h9YSXtHaCR3CEj4LU1B561G1j7FVaeYbX9bKBAoy/GxAW8J5O1n mmw7FnkSHuwO/QDe0COoO0QZ620Cf9IBWYHW4m2M2yh5981lUaiMcNM2kPgsJFYloFo2XGn6 lWU9BrWjEoNDhHZtF+yaPEuwjZo6x/3E2Tu3E5Jj0VpVcE9U1Zq/fquDY79l2RJn5ENogOs5 +Pi0GjVpEYQVWfm0PTCxNPOzOzGR4QB3BNFvABEBAAGJAiUEGAEIAA8FAlWjfaECGwwFCQlm AYAACgkQvWpQHLeLfCZqGxAAlWBWVvjU6xj70GwengiqYZwmW1i8gfS4TNibQT/KRq0zkBnE wgKwXRbVoW38pYVuGa5x/JDQMJDrLAJ0wrCOS3XxbSHCWOl/k2ZD9OaxUeXq6N+OmGTzfrYv PUvWS1Hy04q9AD1dIaMNruZQmvnRfkOk2UDncDIg0166/NTHiYI09H5mpWGpHn/2aT6dmpVw uoM9/rHlF5s5qAAo95tZ0QW2BtIceG9/rbYlL57waSMPF49awvwLQX5RhWoF8mPS5LsBrXXK hmizIsn40tLbi2RtWjzDWgZYitqmmqijeCnDvISN4qJ/nCLO4DjiSGs59w5HR+l0nwePDhOC A4RYZqS1e2Clx1VSkDXFpL3egabcIsqK7CZ6a21r8lXVpo4RnMlQsmXZTnRx4SajFvX7PrRg /02C811fLfh2r5O5if8sKQ6BKKlHpuuioqfj/w9z3B0aQ71e4n1zNJBO1kcdznikPLAbr7jG gkBUXT1yJiwpTfRQr5y2Uo12IJsKxohnNFVYtK8X/R6S0deKPjrZWvAkllgIPcHjMi2Va8yw KTj/JgcpUO5KN906Pf7ywZISe7Kbcc/qnE0YjPPSqFOvoeZvHe6EZCMW9+xZsaipvlqpByQV UHnVg09K9YFvjUBsBPdC8ef6YwgfR9o6AnPmxl0oMUIXkCCC5c99fzJY/k+JAq0EGAEIACAW IQS/HfwKVo8F95V1cJC9alAct4t8JgUCWwqKhgIbAgCBCRC9alAct4t8JnYgBBkWCAAdFiEE FMMcSshOZf56bfAEYhBsURv0pdsFAlsKioYACgkQYhBsURv0pdvELgD/U+y3/hsz0bIjMQJY 0LLxM/rFY9Vz1L43+lQHXjL3MPsA/1lNm5sailsY7aFBVJxAzTa8ZAGWBdVaGo6KCvimDB8G 7joP/jx+oGOmdRogs7mG//H+w9DTnBfPpnfkeiiokGYo/+huWO5V0Ac9tTqZeFc//t/YuYJn wWvS0Rx+KL0fT3eh9BQo47uF4yDiZIiWLNh4Agpup1MUSVsz4MjD0lW6ghtnLcGlIgoVHW0v tPW1m9jATYyJSOG/MC1iDrcYcp9uVYn5tKfkEeQNspuG6iSfS0q3tajPKnT1nJxMTxVOD2RW EIGfaV9Scrou92VD/eC+/8INRsiWS93j3hOKIAV5XRNINFqtzkagPYAP8r6wksjSjh01fSTB p5zxjfsIwWDDzDrqgzwv83CvrLXRV3OlG1DNUDYA52qJr47paH5QMWmHW5TNuoBX8qb6RW/H M3DzPgT+l+r1pPjMPfvL1t7civZUoPuNzoyFpQRj6TvWi2bGGMQKryeYksXG2zi2+avMFnLe lOxGdUZ7jn1SJ6Abba5WL3VrXCP+TUE6bZLgfw8kYa8QSXP3ysyeMI0topHFntBZ8a0KXBNs qqFCBWmTHXfwsfW0VgBmRtPO7eXVBybjJ1VXKR2RZxwSq/GoNXh/yrRXQxbcpZ+QP3/Tttsb FdKciZ4u3ts+5UwYra0BRuvb51RiZR2wRNnUeBnXWagJVTlG7RHBO/2jJOE6wrcdCMjs0Iiw PNWmiVoZA930TvHA5UeGENxdGqo2MvMdRJ54YaIR Message-ID: Date: Wed, 9 Oct 2019 20:14:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 10/9/19 4:43 PM, Akinobu Mita wrote: > 2019年10月9日(水) 5:53 Jacek Anaszewski : >> >> On 10/6/19 4:11 PM, Akinobu Mita wrote: >>> 2019年10月6日(日) 4:17 Jacek Anaszewski : >>>> >>>> On 10/5/19 3:20 PM, Akinobu Mita wrote: >>>>> 2019年10月5日(土) 6:17 Jacek Anaszewski : >>>>>> >>>>>> Hi Akinobu, >>>>>> >>>>>> Why do you think this change is needed? Does it solve >>>>>> some use case for you? >>>>> >>>>> It can be useful when using with an LED trigger that could set the >>>>> brightness values other than LED_FULL or LED_OFF. >>>>> >>>>> The LED CPU trigger for all CPUs (not per CPU) sets the brightness value >>>>> depending on the number of active CPUs. We can define the multi brightness >>>>> level gpio LED with fewer number of GPIO LEDs than the total number of >>>>> CPUs, and the LEDs can be viewed as a level meter. >>>> >>>> Can't you achieve exactly the same effect by creating separate LED class >>>> device for each GPIO LED and registering each of them for separate cpuN >>>> trigger? >>> >>> If there are GPIO LEDs as many as the total number of CPUs, we can. >>> However, if there are only two GPIO LEDs and six CPUs, we can only know >>> the CPU activity for two CPUs out of six CPUs with cpuN trigger. >>> So it's different from using cpu (all) trigger with multi level (2-level) >>> brightness GPIO LED. >> >> OK, that's a reasonable argument. However, this is clearly >> trigger-specific functionality and we should not delegate this >> logic down to the driver. >> >> What you propose should be a responsibility of a trigger that would >> allow registering multiple LEDs for its disposal. This would have to >> be different from existing LED Trigger mechanism, that blindly >> applies trigger event to all LEDs that have registered for it. >> >> Such a trigger would have to be a separate LED (pattern?) class device. >> It would need to be told how many LEDs it is going to manage >> and create files for filling the LED names. This design could be also >> used for defining patterns spanning on multiple LEDs. Just a rough idea. >> We can dwell on it if it catches. > > What do you think about introducing a new led driver and describing a > level meter in the following DT node. > > led-level-meter { > compatible = "led-level-meter"; > leds = <&led0>, <&led1>, <&led2>, <&led3>; > }; > > Setting the brightness of led-level-meter to LED_HALF turns on led0 and > led1 with max brightness and turns off led2 and led3. > > This is inspired by led-backlight driver patchset and Bjorn Andersson's > reply in this thread. Looks interesting, I like the idea. -- Best regards, Jacek Anaszewski