From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F0D3C3A59C for ; Fri, 16 Aug 2019 12:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFE812133F for ; Fri, 16 Aug 2019 12:06:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727007AbfHPMGC (ORCPT ); Fri, 16 Aug 2019 08:06:02 -0400 Received: from mail.steuer-voss.de ([85.183.69.95]:55132 "EHLO mail.steuer-voss.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727110AbfHPMGC (ORCPT ); Fri, 16 Aug 2019 08:06:02 -0400 X-Greylist: delayed 512 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Aug 2019 08:06:01 EDT X-Virus-Scanned: Debian amavisd-new at mail.steuer-voss.de Received: by mail.steuer-voss.de (Postfix, from userid 1000) id 20BAC4D1C5; Fri, 16 Aug 2019 13:57:26 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.steuer-voss.de (Postfix) with ESMTP id 1A9C44D14D; Fri, 16 Aug 2019 13:57:26 +0200 (CEST) Date: Fri, 16 Aug 2019 13:57:26 +0200 (CEST) From: Nikolaus Voss X-X-Sender: nv@fox.voss.local To: "Schmauss, Erik" cc: "Shevchenko, Andriy" , "Rafael J. Wysocki" , Len Brown , "Moore, Robert" , Jacek Anaszewski , Pavel Machek , Dan Murphy , Thierry Reding , "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "linux-leds@vger.kernel.org" , "linux-pwm@vger.kernel.org" , nikolaus.voss@loewensteinmedical.de Subject: RE: [PATCH 1/3] ACPI: Resolve objects on host-directed table loads In-Reply-To: Message-ID: References: <8704391ae3004a6b4dd17975dbcc9e88bd28cf4b.1559127603.git.nikolaus.voss@loewensteinmedical.de> <20190814185055.GZ30120@smile.fi.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed, 14 Aug 2019, Schmauss, Erik wrote: > > >> -----Original Message----- >> From: Shevchenko, Andriy >> Sent: Wednesday, August 14, 2019 11:51 AM >> To: Nikolaus Voss >> Cc: Rafael J. Wysocki ; Len Brown ; >> Moore, Robert ; Schmauss, Erik >> ; Jacek Anaszewski ; >> Pavel Machek ; Dan Murphy ; Thierry >> Reding ; linux-acpi@vger.kernel.org; >> devel@acpica.org; linux-leds@vger.kernel.org; linux-pwm@vger.kernel.org >> Subject: Re: [PATCH 1/3] ACPI: Resolve objects on host-directed table loads >> >> On Wed, May 29, 2019 at 02:18:20PM +0200, Nikolaus Voss wrote: >>> If an ACPI SSDT overlay is loaded after built-in tables have been >>> loaded e.g. via configfs or efivar_ssdt_load() it is necessary to >>> rewalk the namespace to resolve references. Without this, relative and >>> absolute paths like ^PCI0.SBUS or \_SB.PCI0.SBUS are not resolved >>> correctly. >>> >>> Make configfs load use the same method as efivar_ssdt_load(). >> >> This patch brought a regression (bisect log below). >> Now I'm unable to unload the table which was working before. >> >> Reverting (manual, due to ACPICA changes) helps. >> >> Please, consider to revert for this cycle, or fix. I will be glad to test any >> proposed fix. > > We submitted a patch (d1fb5b2f623b1af5a0d2a83d205df1b61f430dc6) > in response to this suggestion and I was not aware that this had been applied. > > Rafael, please revert at least the ACPICA portion of this patch. As I see it, my ACPICA change is not part of 5.3-rc1 any more. Reverting my fix is part of the patch above (d1fb5b2f623b1af5a0d2a83d205df1b61f430dc6) which is already applied. Nevertheless, what is new, is that acpi_ns_initialize_objects() is called in acpi_load_table(). This is necessary to resolve the references in the newly loaded table. Maybe this prevents the table from being unloaded? Niko > > Thanks, > Erik >> >> >> git bisect start >> # good: [0ecfebd2b52404ae0c54a878c872bb93363ada36] Linux 5.2 git bisect >> good 0ecfebd2b52404ae0c54a878c872bb93363ada36 >> # bad: [5f9e832c137075045d15cd6899ab0505cfb2ca4b] Linus 5.3-rc1 git >> bisect bad 5f9e832c137075045d15cd6899ab0505cfb2ca4b >> # bad: [e786741ff1b52769b044b7f4407f39cd13ee5d2d] Merge tag 'staging- >> 5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging >> git bisect bad e786741ff1b52769b044b7f4407f39cd13ee5d2d >> # bad: [8f6ccf6159aed1f04c6d179f61f6fb2691261e84] Merge tag 'clone3-v5.3' >> of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux >> git bisect bad 8f6ccf6159aed1f04c6d179f61f6fb2691261e84 >> # good: [ed63b9c873601ca113da5c7b1745e3946493e9f3] Merge tag >> 'media/v5.3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux- >> media >> git bisect good ed63b9c873601ca113da5c7b1745e3946493e9f3 >> # bad: [4b4704520d97b74e045154fc3b844b73ae4e7ebd] Merge tag 'acpi-5.3- >> rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm >> git bisect bad 4b4704520d97b74e045154fc3b844b73ae4e7ebd >> # good: [e3303268f9cfa4eb7c2217df471417d4327109fd] ASoC: soc-core: don't >> use soc_find_component() at snd_soc_find_dai() git bisect good >> e3303268f9cfa4eb7c2217df471417d4327109fd >> # good: [3c53c6255d598db7084c5c3d7553d7200e857818] Merge tag 'asoc- >> v5.3' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for- >> linus git bisect good 3c53c6255d598db7084c5c3d7553d7200e857818 >> # good: [4cdd5f9186bbe80306e76f11da7ecb0b9720433c] Merge tag 'sound- >> 5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound >> git bisect good 4cdd5f9186bbe80306e76f11da7ecb0b9720433c >> # good: [13b06b78c772d64e2207e4a5a5329856fe2bf241] Merge branches >> 'pm-opp', 'pm-misc', 'pm-avs' and 'pm-tools' >> git bisect good 13b06b78c772d64e2207e4a5a5329856fe2bf241 >> # good: [cf2d213e49fdf47e4c10dc629a3659e0026a54b8] Merge tag 'pm-5.3- >> rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm >> git bisect good cf2d213e49fdf47e4c10dc629a3659e0026a54b8 >> # bad: [02a93f35f57fe5d4d1bac0ac8496884235e2fd2e] ACPICA: Update >> version to 20190703 git bisect bad >> 02a93f35f57fe5d4d1bac0ac8496884235e2fd2e >> # bad: [d4ca763eed3bcc227f220beb11ff4eb2fa548755] Merge ACPI tables >> handling changes for v5.3. >> git bisect bad d4ca763eed3bcc227f220beb11ff4eb2fa548755 >> # bad: [d06c47e3dd07fdf3f07e8fc45f2ce655e9b295c5] ACPI: configfs: Resolve >> objects on host-directed table loads git bisect bad >> d06c47e3dd07fdf3f07e8fc45f2ce655e9b295c5 >> # good: [c78fea61f0c1f8568fbbb36ac3d1e1c85a903ae4] ACPI: tables: Allow >> BGRT to be overridden git bisect good >> c78fea61f0c1f8568fbbb36ac3d1e1c85a903ae4 >> # first bad commit: [d06c47e3dd07fdf3f07e8fc45f2ce655e9b295c5] ACPI: >> configfs: Resolve objects on host-directed table loads >> >> -- >> With Best Regards, >> Andy Shevchenko >> > >