From: Dan Murphy <dmurphy@ti.com>
To: "Marek Behún" <marek.behun@nic.cz>, linux-leds@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, <jacek.anaszewski@gmail.com>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: leds: add cznic,turris-omnia-leds binding
Date: Wed, 15 Jul 2020 07:47:28 -0500 [thread overview]
Message-ID: <c1bfdb2a-f11e-9f67-1569-10c48f40407c@ti.com> (raw)
In-Reply-To: <20200715124034.9804-2-marek.behun@nic.cz>
Marek
On 7/15/20 7:40 AM, Marek Behún wrote:
> Add device-tree bindings documentation for Turris Omnia RGB LEDs.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> ---
> .../leds/cznic,turris-omnia-leds.yaml | 88 +++++++++++++++++++
> 1 file changed, 88 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> new file mode 100644
> index 000000000000..0b33ebf22e27
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/cznic,turris-omnia-leds.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CZ.NIC's Turris Omnia LEDs driver
> +
> +maintainers:
> + - Marek Behún <marek.behun@nic.cz>
> +
> +description:
> + This module adds support for the RGB LEDs found on the fron panel of the
s/fron/front
> + Turris Omnia router. There are 12 RGB LEDs, they are controlled by device's
> + microcontroller with which the system communicates via I2C. Each LED is
This is a bit confusing and reads very rough can maybe
There are 12 RGB LEDs that are controlled via a micro controller that
communicates via the I2C bus.
Dan
next prev parent reply other threads:[~2020-07-15 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 12:40 [PATCH v4 0/2] Add Turris Omnia LEDs driver Marek Behún
2020-07-15 12:40 ` [PATCH v4 1/2] dt-bindings: leds: add cznic,turris-omnia-leds binding Marek Behún
2020-07-15 12:47 ` Dan Murphy [this message]
2020-07-15 13:02 ` Marek Behún
2020-07-15 12:40 ` [PATCH v4 2/2] leds: initial support for Turris Omnia LEDs Marek Behún
2020-07-15 13:27 ` Dan Murphy
2020-07-15 19:03 ` Marek Behún
2020-07-15 19:10 ` Dan Murphy
2020-07-16 10:32 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1bfdb2a-f11e-9f67-1569-10c48f40407c@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).