linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Enzo Matsumiya <ematsumiya@suse.de>,
	linux-leds@vger.kernel.org, linux-block@vger.kernel.org
Cc: u.kleine-koenig@pengutronix.de, Jens Axboe <axboe@kernel.dk>,
	Pavel Machek <pavel@ucw.cz>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] leds: trigger: implement block trigger
Date: Fri, 30 Apr 2021 11:52:44 -0700	[thread overview]
Message-ID: <d1e96245-6afa-0a67-2b56-de2dd2fda948@infradead.org> (raw)
In-Reply-To: <20210430183216.27458-3-ematsumiya@suse.de>

On 4/30/21 11:32 AM, Enzo Matsumiya wrote:
> diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig
> index b77a01bd27f4..bead31a19148 100644
> --- a/drivers/leds/trigger/Kconfig
> +++ b/drivers/leds/trigger/Kconfig
> @@ -153,4 +153,14 @@ config LEDS_TRIGGER_TTY
>  
>  	  When build as a module this driver will be called ledtrig-tty.
>  
> +config LEDS_TRIGGER_BLOCK
> +	tristate "LED Block Device Trigger"
> +	depends on BLOCK
> +	default m

Drop the "default m". We don't enable drivers (even to build modules)
unless they are necessary, e.g., for booting.

> +	help
> +	  This allows LEDs to be controlled by block device activity.
> +	  This trigger doesn't require the lower level drivers to have any
> +	  instrumentation. The activity is collected by polling the disk stats.
> +	  If unsure, say Y.
> +
>  endif # LEDS_TRIGGERS

thanks.
-- 
~Randy

  reply	other threads:[~2021-04-30 18:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 18:32 [RFC PATCH 0/2] leds: trigger: introduce block trigger Enzo Matsumiya
2021-04-30 18:32 ` [RFC PATCH 1/2] block: export block_class and disk_type symbols Enzo Matsumiya
2021-05-01  6:24   ` Greg Kroah-Hartman
2021-05-03  2:37     ` Enzo Matsumiya
2021-05-03  4:48       ` Greg Kroah-Hartman
2021-05-03  7:04   ` Christoph Hellwig
2021-05-03 16:50     ` Enzo Matsumiya
2021-04-30 18:32 ` [RFC PATCH 2/2] leds: trigger: implement block trigger Enzo Matsumiya
2021-04-30 18:52   ` Randy Dunlap [this message]
2021-05-03  2:38     ` Enzo Matsumiya
2021-04-30 20:11   ` Marek Behun
2021-05-03  2:46     ` Enzo Matsumiya
2021-05-03  5:53   ` Hannes Reinecke
2021-05-03 10:11     ` Pavel Machek
2021-05-03 16:56       ` Enzo Matsumiya
2021-05-04 15:43         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1e96245-6afa-0a67-2b56-de2dd2fda948@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=ematsumiya@suse.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).