linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] leds: lm3532: Switch to use fwnode_property_count_uXX()
Date: Wed, 24 Jul 2019 10:19:31 -0500	[thread overview]
Message-ID: <dbd94f8c-04a4-05de-40d0-d9c0ad9dac0f@ti.com> (raw)
In-Reply-To: <20190723201459.70449-1-andriy.shevchenko@linux.intel.com>

Andy

On 7/23/19 3:14 PM, Andy Shevchenko wrote:
> Use fwnode_property_count_uXX() directly, that makes code neater.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for the update with the new call

Acked-by: Dan Murphy <dmurphy@ti.com>


> ---
>   drivers/leds/leds-lm3532.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
> index 180895b83b88..646100724971 100644
> --- a/drivers/leds/leds-lm3532.c
> +++ b/drivers/leds/leds-lm3532.c
> @@ -549,10 +549,7 @@ static int lm3532_parse_node(struct lm3532_data *priv)
>   				lm3532_als_configure(priv, led);
>   		}
>   
> -		led->num_leds = fwnode_property_read_u32_array(child,
> -							       "led-sources",
> -							       NULL, 0);
> -
> +		led->num_leds = fwnode_property_count_u32(child, "led-sources");
>   		if (led->num_leds > LM3532_MAX_LED_STRINGS) {
>   			dev_err(&priv->client->dev, "To many LED string defined\n");
>   			continue;

  parent reply	other threads:[~2019-07-24 15:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 20:14 [PATCH v1 1/3] leds: lm3532: Switch to use fwnode_property_count_uXX() Andy Shevchenko
2019-07-23 20:14 ` [PATCH v1 2/3] leds: lm36274: " Andy Shevchenko
2019-07-24 15:19   ` Dan Murphy
2019-07-23 20:14 ` [PATCH v1 3/3] leds: lm3697: " Andy Shevchenko
2019-07-24 15:20   ` Dan Murphy
2019-07-24 15:19 ` Dan Murphy [this message]
2019-07-24 21:03 ` [PATCH v1 1/3] leds: lm3532: " Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbd94f8c-04a4-05de-40d0-d9c0ad9dac0f@ti.com \
    --to=dmurphy@ti.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).