From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>,
robh@kernel.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v29 13/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function
Date: Sun, 12 Jul 2020 17:31:24 +0200 [thread overview]
Message-ID: <e2a2fe12-b5e8-6a62-3dc3-f45019ade330@gmail.com> (raw)
In-Reply-To: <20200711202419.GA18347@duo.ucw.cz>
On 7/11/20 10:24 PM, Pavel Machek wrote:
> On Sat 2020-07-11 19:19:22, Jacek Anaszewski wrote:
>> On 7/11/20 5:57 PM, Pavel Machek wrote:
>>> Hi!
>>>
>>>> Add the multicolor brightness call back to support the multicolor
>>>> framework. This call back allows setting brightness on grouped channels
>>>
>>> Extra space before "brightness".
>>
>> And before "This".
>
> That one is intentional, I believe.
>
> https://www.independent.co.uk/life-style/gadgets-and-tech/news/one-space-or-two-spaces-after-a-full-stop-scientists-have-finally-found-the-answer-a8337646.html
>
> We are using fixed width fonts, so typewriter rules still apply here.
But see the article [0].
Also, in [1], in the section "Computer era" you can find opposite
examples in the modern systems.
And grep returns following numbers for kernel Documentation folder:
$ rgrep "[A-Za-z0-9]\. " Documentation/ | wc -l
18449
$ rgrep "[A-Za-z0-9]\. " Documentation/ | wc -l
63067
I prefer single space but will not fight for that too hard.
Nonetheless, it would be good to use one style consistently,
since most files I've looked at had problem with that.
Both DT and LED documentation in this set is not consistent
in this regard as well.
[0]
https://www.instructionalsolutions.com/blog/one-space-vs-two-after-period
[1] https://en.wikipedia.org/wiki/Sentence_spacing
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-07-12 15:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 18:59 [PATCH v29 00/16] Multicolor Framework v29 Dan Murphy
2020-06-22 18:59 ` [PATCH v29 01/16] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-07-04 12:48 ` Pavel Machek
2020-07-09 19:24 ` Rob Herring
2020-07-12 19:52 ` Pavel Machek
2020-06-22 18:59 ` [PATCH v29 02/16] leds: Add multicolor ID to the color ID list Dan Murphy
2020-06-22 18:59 ` [PATCH v29 03/16] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-07-11 15:57 ` Pavel Machek
2020-07-13 13:34 ` Dan Murphy
2020-06-22 18:59 ` [PATCH v29 04/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-07-09 19:25 ` Rob Herring
2020-06-22 18:59 ` [PATCH v29 05/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-07-12 17:21 ` Marek Behun
2020-07-13 12:36 ` Dan Murphy
2020-06-22 18:59 ` [PATCH v29 06/16] dt-bindings: leds: Convert leds-lp55xx to yaml Dan Murphy
2020-07-09 19:25 ` Rob Herring
2020-06-22 18:59 ` [PATCH v29 07/16] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-06-22 18:59 ` [PATCH v29 08/16] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-06-22 18:59 ` [PATCH v29 09/16] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-06-22 18:59 ` [PATCH v29 10/16] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-06-22 18:59 ` [PATCH v29 11/16] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-06-22 18:59 ` [PATCH v29 12/16] ARM: defconfig: u8500: Add LP55XX_COMMON config flag Dan Murphy
2020-07-11 15:57 ` Pavel Machek
2020-06-22 18:59 ` [PATCH v29 13/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-07-11 15:57 ` Pavel Machek
2020-07-11 17:19 ` Jacek Anaszewski
2020-07-11 20:24 ` Pavel Machek
2020-07-12 15:31 ` Jacek Anaszewski [this message]
2020-06-22 18:59 ` [PATCH v29 14/16] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-06-22 18:59 ` [PATCH v29 15/16] leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros Dan Murphy
2020-06-22 18:59 ` [PATCH v29 16/16] leds: lp5523: Fix various formatting issues in the code Dan Murphy
2020-07-04 12:47 ` [PATCH v29 00/16] Multicolor Framework v29 Pavel Machek
2020-07-06 12:31 ` Dan Murphy
2020-07-07 15:36 ` Dan Murphy
2020-07-11 20:29 ` Pavel Machek
2020-07-12 17:13 ` Marek Behun
2020-07-12 19:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2a2fe12-b5e8-6a62-3dc3-f45019ade330@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).