From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fenglin Wu <quic_fenglinw@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com
Subject: Re: [PATCH v1 2/2] dt-bindings: add bindings for QCOM flash LED
Date: Thu, 29 Sep 2022 13:13:58 +0200 [thread overview]
Message-ID: <e5d8c7f3-3d06-f9e0-0d81-32ceb371f27f@linaro.org> (raw)
In-Reply-To: <107dfb13-85fc-123d-d244-962ce6c1cdb7@quicinc.com>
On 29/09/2022 12:56, Fenglin Wu wrote:
>> If driver binds to only one compatible, it is expected to be the
>> fallback for all others. There might be exception for this rule but it
>> does not look like here.
>>
>>> But I was thinking to give out the PMIC names
>>> here so anyone who is using the driver could easily identify if the
>>> driver is suitable for the HW that he/she is using.
>>
>> I did not say to remove other compatibles, but to use one fallback for
>> all of them.
>>
> Do you mean to update it similar to this?
>
> compatible:
> items:
> - enum:
> - qcom,pm8150c-flash-led
> - qcom,pm8150l-flash-led
> - qcom,pm8350c-flash-led
> - const:
> - qcom,spmi-flash-led
Yes, just const is not a list, so "const: qcom,spmi-flash-led"
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-29 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220928024239.3843909-1-quic_fenglinw@quicinc.com>
2022-09-28 2:42 ` [PATCH v1 1/2] leds: flash: add driver to support flash LED module in QCOM PMICs Fenglin Wu
2022-09-28 2:42 ` [PATCH v1 2/2] dt-bindings: add bindings for QCOM flash LED Fenglin Wu
2022-09-28 8:21 ` Krzysztof Kozlowski
2022-09-29 2:20 ` Fenglin Wu
2022-09-29 7:06 ` Krzysztof Kozlowski
2022-09-29 10:56 ` Fenglin Wu
2022-09-29 11:13 ` Krzysztof Kozlowski [this message]
2022-09-28 12:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d8c7f3-3d06-f9e0-0d81-32ceb371f27f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=quic_collinsd@quicinc.com \
--cc=quic_fenglinw@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).