* [PATCH 0/1] Resend leds-lp5562 allow firmware files up to the maximum length
@ 2019-07-17 21:56 Nick Stoughton
2019-07-17 21:56 ` [PATCH 1/1] leds: " Nick Stoughton
0 siblings, 1 reply; 3+ messages in thread
From: Nick Stoughton @ 2019-07-17 21:56 UTC (permalink / raw)
To: linux-leds; +Cc: Nick Stoughton
As requested, resending patch with git-send-email.
Nick Stoughton (1):
leds: leds-lp5562 allow firmware files up to the maximum length
drivers/leds/leds-lp5562.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--
Nick Stoughton
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] leds: leds-lp5562 allow firmware files up to the maximum length
2019-07-17 21:56 [PATCH 0/1] Resend leds-lp5562 allow firmware files up to the maximum length Nick Stoughton
@ 2019-07-17 21:56 ` Nick Stoughton
2019-07-17 22:19 ` Jacek Anaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Nick Stoughton @ 2019-07-17 21:56 UTC (permalink / raw)
To: linux-leds; +Cc: Nick Stoughton
Firmware files are in ASCII, using 2 hex characters per byte. The
maximum length of a firmware string is therefore
16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64
Signed-off-by: Nick Stoughton <nstoughton@logitech.com>
---
drivers/leds/leds-lp5562.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
index 37632fc63741..e00117e3b50d 100644
--- a/drivers/leds/leds-lp5562.c
+++ b/drivers/leds/leds-lp5562.c
@@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip)
{
const struct firmware *fw = chip->fw;
- if (fw->size > LP5562_PROGRAM_LENGTH) {
+ /*
+ * the firmware is encoded in ascii hex character, with 2 chars
+ * per byte
+ */
+ if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) {
dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
fw->size);
return;
--
Nick Stoughton
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] leds: leds-lp5562 allow firmware files up to the maximum length
2019-07-17 21:56 ` [PATCH 1/1] leds: " Nick Stoughton
@ 2019-07-17 22:19 ` Jacek Anaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2019-07-17 22:19 UTC (permalink / raw)
To: Nick Stoughton, linux-leds
Hi Nick,
Thank you for the update. Now it applies cleanly.
On 7/17/19 11:56 PM, Nick Stoughton wrote:
> Firmware files are in ASCII, using 2 hex characters per byte. The
> maximum length of a firmware string is therefore
>
> 16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64
>
> Signed-off-by: Nick Stoughton <nstoughton@logitech.com>
> ---
> drivers/leds/leds-lp5562.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
> index 37632fc63741..e00117e3b50d 100644
> --- a/drivers/leds/leds-lp5562.c
> +++ b/drivers/leds/leds-lp5562.c
> @@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip)
> {
> const struct firmware *fw = chip->fw;
>
> - if (fw->size > LP5562_PROGRAM_LENGTH) {
> + /*
> + * the firmware is encoded in ascii hex character, with 2 chars
> + * per byte
> + */
If you used scripts/checkpatch.pl on this patch then you would
notice some problems here. I fixed them up by myself.
Added also the tag to the commit message:
Fixes: ff45262a85db ("leds: add new LP5562 LED driver")
and applied.
Thanks.
> + if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) {
> dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n",
> fw->size);
> return;
>
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-17 22:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 21:56 [PATCH 0/1] Resend leds-lp5562 allow firmware files up to the maximum length Nick Stoughton
2019-07-17 21:56 ` [PATCH 1/1] leds: " Nick Stoughton
2019-07-17 22:19 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).