From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE89C432C3 for ; Thu, 14 Nov 2019 12:57:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4504F206E1 for ; Thu, 14 Nov 2019 12:57:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RRjFSq/J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbfKNM5c (ORCPT ); Thu, 14 Nov 2019 07:57:32 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:43724 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbfKNM5b (ORCPT ); Thu, 14 Nov 2019 07:57:31 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAECvP7i126944; Thu, 14 Nov 2019 06:57:25 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573736245; bh=bCj1LDwNUVKQlXqlbNZOR3TzhAvoi+DmugM5a3M9x+w=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=RRjFSq/J+GPSPvRKrdSEwBgCRZ+4YkdqV1HzSCISWQ9Buhre7RiK7FXbU4rAGaFzD ibvb0jHIYkrksY/f4R/hLmmOIBm8R/txwQz1wwi7UcbWGG8GaQPlLRXY3BA2bmFLOG 4F4wg6Anb0tppT1c7yTj1ekVAvSlJHeD+R2emYPc= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xAECvOpq099907 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 14 Nov 2019 06:57:24 -0600 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 14 Nov 2019 06:57:24 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 14 Nov 2019 06:57:24 -0600 Received: from [10.250.33.226] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAECvOYu106064; Thu, 14 Nov 2019 06:57:24 -0600 Subject: Re: [PATCH v16 04/19] leds: multicolor: Introduce a multicolor class definition To: Martin Fuzzey , , CC: , References: <20191104123707.31930-1-dmurphy@ti.com> <20191104123707.31930-5-dmurphy@ti.com> From: Dan Murphy Message-ID: Date: Thu, 14 Nov 2019 06:56:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Martin On 11/14/19 5:24 AM, Martin Fuzzey wrote: > Hi Dan, > > On 04/11/2019 13:36, Dan Murphy wrote: >> +int devm_led_classdev_multicolor_register_ext(struct device *parent, >> +                         struct led_classdev_mc *mcled_cdev, >> +                          struct led_init_data *init_data) >> +{ >> +    struct led_classdev_mc **dr; >> +    int ret; >> + >> +    dr = devres_alloc(devm_led_classdev_multicolor_release, >> +              sizeof(*dr), GFP_KERNEL); >> +    if (!dr) >> +        return -ENOMEM; >> + >> +    ret = led_classdev_multicolor_register(parent, mcled_cdev); > > > This drops init_data, should be led_classdev_multicolor_register_ex > Thanks for the issue I will fix and send v17 Dan