From: Dan Murphy <dmurphy@ti.com>
To: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
tony@atomide.com, lee.jones@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Date: Fri, 8 Mar 2019 07:28:19 -0600 [thread overview]
Message-ID: <f618b1dc-abf2-88ba-9b73-1a70471adc6b@ti.com> (raw)
In-Reply-To: <20190307220947.20057-4-dmurphy@ti.com>
Hello
On 3/7/19 4:09 PM, Dan Murphy wrote:
> Introduce the Texas Instruments LM3532 White LED driver.
> The driver supports ALS configurability or manual brightness
> control.
>
> The driver also supports associating LED strings with specific
> control banks in a group or as individually controlled strings.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/leds/Kconfig | 10 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-lm3532.c | 595 +++++++++++++++++++++++++
> include/dt-bindings/leds/leds-lm3532.h | 72 +++
> 4 files changed, 678 insertions(+)
> create mode 100644 drivers/leds/leds-lm3532.c
> create mode 100644 include/dt-bindings/leds/leds-lm3532.h
>
After thinking about this dt header I am not happy about having it.
I am thinking of removing this file completely and doing some calculations in the driver
file for the impedance, averaging time and ramp times.
I would still like to get comments on the rest of the code but in v2 the dt bindings header will
go away.
Dan
<snip>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2019-03-08 13:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 22:09 [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-07 22:09 ` [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-03-08 15:14 ` Pavel Machek
2019-03-08 15:45 ` Dan Murphy
2019-03-08 21:06 ` Pavel Machek
2019-03-08 21:08 ` Dan Murphy
2019-03-07 22:09 ` [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references Dan Murphy
2019-03-07 22:09 ` [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-08 13:28 ` Dan Murphy [this message]
2019-03-10 19:49 ` Jacek Anaszewski
2019-03-11 11:36 ` Dan Murphy
2019-03-11 17:22 ` Jacek Anaszewski
2019-03-11 17:24 ` Dan Murphy
2019-03-11 17:30 ` Joe Perches
2019-03-11 17:47 ` Dan Murphy
2019-03-13 15:49 ` Joe Perches
2019-03-21 14:28 [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-21 14:28 ` [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-22 22:16 ` Tony Lindgren
2019-03-25 12:35 ` Dan Murphy
2019-03-25 14:54 ` Tony Lindgren
2019-03-25 16:01 ` Dan Murphy
2019-03-28 21:04 ` Sebastian Reichel
2019-04-03 20:06 ` Tony Lindgren
2019-04-03 23:55 ` Tony Lindgren
2019-04-04 0:09 ` Tony Lindgren
2019-04-04 18:48 ` Jacek Anaszewski
2019-04-04 19:23 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f618b1dc-abf2-88ba-9b73-1a70471adc6b@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).