From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>,
pavel@ucw.cz, dmurphy@ti.com, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: netxbig: Add of_node_put() in netxbig_leds_get_of_pdata()
Date: Mon, 29 Jul 2019 21:20:25 +0200 [thread overview]
Message-ID: <f7fb173a-be50-da46-1aa0-5ec24515e2df@gmail.com> (raw)
In-Reply-To: <20190729065356.26793-1-nishkadg.linux@gmail.com>
Hi Nishka,
Thank you for the patch.
On 7/29/19 8:53 AM, Nishka Dasgupta wrote:
> The variable gpio_ext_np in the function netxbig_leds_get_of_pdata takes
> the value returned by of_parse_phandle; hence, it must be put in order
> to prevent a memory leak. Add an of_node_put for gpio_ext_np before a
> return statement, and move a pre-existing of_node_put statement to right
> after the last usage of this variable.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/leds/leds-netxbig.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
> index 10497a466775..654d83bbc450 100644
> --- a/drivers/leds/leds-netxbig.c
> +++ b/drivers/leds/leds-netxbig.c
> @@ -388,12 +388,14 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
> }
>
> gpio_ext = devm_kzalloc(dev, sizeof(*gpio_ext), GFP_KERNEL);
> - if (!gpio_ext)
> + if (!gpio_ext) {
> + of_node_put(gpio_ext_np);
> return -ENOMEM;
> + }
> ret = gpio_ext_get_of_pdata(dev, gpio_ext_np, gpio_ext);
> + of_node_put(gpio_ext_np);
> if (ret)
> return ret;
> - of_node_put(gpio_ext_np);
> pdata->gpio_ext = gpio_ext;
>
> /* Timers (optional) */
>
Applied.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2019-07-29 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 6:53 [PATCH] leds: netxbig: Add of_node_put() in netxbig_leds_get_of_pdata() Nishka Dasgupta
2019-07-29 11:32 ` Pavel Machek
2019-07-29 19:20 ` Jacek Anaszewski
2019-07-29 19:20 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7fb173a-be50-da46-1aa0-5ec24515e2df@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).