From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz, robh@kernel.org
Cc: kbuild-all@lists.01.org, devicetree@vger.kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v27 11/15] leds: lp55xx: Add multicolor framework support to lp55xx
Date: Thu, 18 Jun 2020 23:21:45 +0200 [thread overview]
Message-ID: <fc410dfb-70d1-1b8b-3b6d-0de1c6c84ec2@gmail.com> (raw)
In-Reply-To: <fc1ae702-0734-973d-9e3c-22b8f8d5c873@ti.com>
Dan,
On 6/18/20 12:33 AM, Dan Murphy wrote:
> Jacek
>
> On 6/17/20 4:41 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 6/17/20 9:22 PM, Dan Murphy wrote:
>>> Pavel/Jacek
>>>
>>> On 6/17/20 11:28 AM, kernel test robot wrote:
>>>> Hi Dan,
>>>>
>>>> I love your patch! Yet something to improve:
>>>>
>>>> [auto build test ERROR on pavel-linux-leds/for-next]
>>>> [cannot apply to j.anaszewski-leds/for-next]
>>>> [if your patch is applied to the wrong git tree, please drop us a
>>>> note to help
>>>> improve the system. BTW, we also suggest to use '--base' option to
>>>> specify the
>>>> base tree in git format-patch, please see
>>>> https://stackoverflow.com/a/37406982]
>>>>
>>>> url:
>>>> https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework-v27/20200616-042217
>>>>
>>>> base:
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git
>>>> for-next
>>>> config: ia64-randconfig-r015-20200617 (attached as .config)
>>>> compiler: ia64-linux-gcc (GCC) 9.3.0
>>>> reproduce (this is a W=1 build):
>>>> wget
>>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>>>> -O ~/bin/make.cross
>>>> chmod +x ~/bin/make.cross
>>>> # save the attached .config to linux build tree
>>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
>>>> make.cross ARCH=ia64
>>>>
>>>> If you fix the issue, kindly add following tag as appropriate
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>
>>>> All errors (new ones prefixed by >>, old ones prefixed by <<):
>>>>
>>>> ia64-linux-ld: drivers/leds/leds-lp55xx-common.o: in function
>>>> `lp55xx_set_mc_brightness':
>>>>>> drivers/leds/leds-lp55xx-common.c:146: undefined reference to
>>>>>> `led_mc_calc_color_components'
>>>> ia64-linux-ld: drivers/leds/leds-lp55xx-common.o: in function
>>>> `devm_led_classdev_multicolor_register':
>>>>>> include/linux/led-class-multicolor.h:74: undefined reference to
>>>>>> `devm_led_classdev_multicolor_register_ext'
>>>> vim +146 drivers/leds/leds-lp55xx-common.c
>>>>
>>>> 138
>>>> 139 static int lp55xx_set_mc_brightness(struct led_classdev
>>>> *cdev,
>>>> 140 enum led_brightness brightness)
>>>> 141 {
>>>> 142 struct led_classdev_mc *mc_dev = lcdev_to_mccdev(cdev);
>>>> 143 struct lp55xx_led *led = mcled_cdev_to_led(mc_dev);
>>>> 144 struct lp55xx_device_config *cfg = led->chip->cfg;
>>>> 145
>>>> > 146 led_mc_calc_color_components(&led->mc_cdev, brightness);
>>>> 147 return cfg->multicolor_brightness_fn(led);
>>>> 148
>>>
>>> Well this was a mess to figure out.
>>>
>>> The only fix I can figure out here is to remove the
>>>
>>> depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR
>>>
>>> from each child device and add
>>>
>>> select LEDS_CLASS_MULTI_COLOR
>>>
>>> to the LP55XX_COMMON
>>>
>>> This way the Multi color framework will inherit the symbol that was
>>> set by the COMMON flag which is inherited by majority from the child
>>> flags.
>>
>> Did you try this?
>>
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -398,6 +398,7 @@ config LEDS_LP50XX
>> config LEDS_LP55XX_COMMON
>> tristate "Common Driver for TI/National
>> LP5521/5523/55231/5562/8501"
>> depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 ||
>> LEDS_LP8501
>> + depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR
>> depends on OF
>> select FW_LOADER
>> select FW_LOADER_USER_HELPER
>>
>>
> Yes I did
>
> That gave unmet dependencies.
>
> WARNING: unmet direct dependencies detected for LEDS_LP55XX_COMMON
> Depends on [m]: NEW_LEDS [=y] && (LEDS_LP5521 [=n] || LEDS_LP5523
> [=m] || LEDS_LP5562 [=y] || LEDS_LP8501 [=y]) && (LEDS_CLASS_MULTI_COLOR
> [=m] || !LEDS_CLASS_MULTI_COLOR [=m]) && OF [=y]
> Selected by [y]:
> - LEDS_LP5562 [=y] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=y]
> - LEDS_LP8501 [=y] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=y]
> Selected by [m]:
> - LEDS_LP5523 [=m] && NEW_LEDS [=y] && LEDS_CLASS [=y] && I2C [=y] &&
> (LEDS_CLASS_MULTI_COLOR [=m] || !LEDS_CLASS_MULTI_COLOR [=m])
>
When I was testing that yesterday I also had the same warning at some
point of testing different Kconfig setups, but with what I showed above
it ceased to appear. Now every time I am doing "make oldconfig" the
CONFIG_LEDS_LP55XX_COMMON=y entry gets changed to =m with the config
from the test bot.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-06-18 21:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 20:15 [RESEND PATCH v27 00/15] Multicolor Framework v27 Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 01/15] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 02/15] leds: Add multicolor ID to the color ID list Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 03/15] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 04/15] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 05/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 06/15] dt-bindings: leds: Convert leds-lp55xx to yaml Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 07/15] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 08/15] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 09/15] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 10/15] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 11/15] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-06-17 16:28 ` kernel test robot
2020-06-17 19:22 ` Dan Murphy
2020-06-17 21:41 ` Jacek Anaszewski
2020-06-17 22:33 ` Dan Murphy
2020-06-18 21:21 ` Jacek Anaszewski [this message]
2020-06-18 21:44 ` Dan Murphy
2020-06-18 22:09 ` Jacek Anaszewski
2020-06-18 23:26 ` Jacek Anaszewski
2020-06-18 23:38 ` Dan Murphy
[not found] ` <04473d1d-5cd8-7d1f-7c5d-8d8b582df464@ti.com>
2020-06-19 22:10 ` Jacek Anaszewski
2020-06-21 14:12 ` Dan Murphy
2020-06-21 20:24 ` Jacek Anaszewski
2020-06-22 12:42 ` Jacek Anaszewski
2020-06-22 12:45 ` Dan Murphy
2020-06-22 13:04 ` Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 12/15] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 13/15] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 14/15] leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros Dan Murphy
2020-06-15 20:15 ` [RESEND PATCH v27 15/15] leds: lp5523: Fix various formatting issues in the code Dan Murphy
2020-06-15 20:27 ` [RESEND PATCH v27 00/15] Multicolor Framework v27 Pavel Machek
2020-06-15 20:31 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc410dfb-70d1-1b8b-3b6d-0de1c6c84ec2@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).