From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA95C433FE for ; Fri, 22 Oct 2021 07:27:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D822A610A1 for ; Fri, 22 Oct 2021 07:27:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231898AbhJVH3a (ORCPT ); Fri, 22 Oct 2021 03:29:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:47086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231334AbhJVH33 (ORCPT ); Fri, 22 Oct 2021 03:29:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F0A2060F46; Fri, 22 Oct 2021 07:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634887632; bh=dzqi7vFMuKP+qh6hHtsilh+1qXu9+uZu4RceOFaDhPs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=m3ZqrcYmmw8AP/B8mqIGND2ZFwuU+/JnDkYfwjDS6AdpCcWt6dlBjOTe3qeEOIS5s 1pMKZEW+nHzlXshawJp+D1uFRH0cZZWr5fG6gRGsSGtbMmaDNO7SDkG8WJ4bOXrI3C BUEnDRPxWMZlM0u9OYjMu0NbDnySb5oFz40lZRmsT0t9jWfPPPIeEYHrBNoCrcNkOc mW0QqBwWgw8W7sgzTTxYdaWt0QdAU+Y8yMm6FtVzUnH0bP7pp18Vq3X9bulzGy4FJ/ iaRI/21fsVKDukBKeMVdEBNtw/+KaiU78QEi7NJO5EnnYiQdqAECkOT2KbRM4gyejP +0sB3qSiD0dSg== Date: Fri, 22 Oct 2021 09:27:08 +0200 (CEST) From: Jiri Kosina To: Pavel Machek cc: Roderick Colenbrander , Roderick Colenbrander , Benjamin Tissoires , linux-input , linux-leds@vger.kernel.org, "Daniel J . Ogorchock" , Roderick Colenbrander Subject: Re: [PATCH v3 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers. In-Reply-To: <20211022072115.GA25215@amd> Message-ID: References: <20210908165539.3102929-1-roderick.colenbrander@sony.com> <20210908165539.3102929-3-roderick.colenbrander@sony.com> <20210927141109.GB5809@duo.ucw.cz> <20211013074849.GA10172@amd> <20211022072115.GA25215@amd> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, 22 Oct 2021, Pavel Machek wrote: > > > > Ok, so let's put it in the common place. I'll take this patch through > > > > LED tree if you resubmit it. You still may want to use local defines > > > > so you can apply the other patches without waiting. > > > > > > Pavel, why complicate it so much? Given how trivial the patch is, the > > > easiest way is what's usually done in such cases (where substantial patch > > > depends on a tiny trivial change elsewhere) -- take it through HID tree > > > with your Reviewed-by / Acked-by:. > > > > > > Do you see any issue with that? > > > > Pavel, another week has passed. I am considering just including the > > trivial LED #define additions and take them through hid.git unless I hear > > from you today. > > I'd prefer not to deal with rejects / common immutable branches / etc. I am not proposing common immutable branch; and if there are going to be trivial cotext conflicts because of that, those will be sorted out by Linus without you even noticing. > You don't _need_ the defines at all As I've already pointed to you in several threads, we have quite a lot of code queued that does depend on the defines. > and you don't need them in the common place. I compltely fail to see the point of having them teporarily local before you manage to finally do something about the trivial addition to proper shared header. > Just merge the patch without the defines. I'll merge the defines. That > seems like least complex solution to me. That would cause my tree not to build. -- Jiri Kosina SUSE Labs