From: Zhao Heming <heming.zhao@suse.com>
To: linux-lvm@redhat.com
Cc: Zhao Heming <heming.zhao@suse.com>
Subject: [linux-lvm] [PATCH v2] lvdisplay: dispaly partial when underlying devs missing
Date: Sat, 22 Aug 2020 10:38:11 +0800 [thread overview]
Message-ID: <1598063891-25553-1-git-send-email-heming.zhao@suse.com> (raw)
reproducible steps:
1. vgcreate vg1 /dev/sda /dev/sdb
2. lvcreate --type raid0 -l 100%FREE -n raid0lv vg1
3. do remove the /dev/sdb action
4. lvdisplay show wrong 'LV Status'
After removing raid0 type LV underlying dev, lvdisplay still display 'available'.
With this patch, lvdisplay will show
from:
LV Status available
to:
LV Status NOT available (partial)
Other LV type (like raid1, raid5), lvdisplay will show
from:
LV Status available
to:
LV Status available (partial)
Signed-off-by: Zhao Heming <heming.zhao@suse.com>
---
v2:
- add special handle for raid0 type.
- print 'partial' if lv is partial status.
- change comments, add raid0 & other raid types cases.
---
lib/display/display.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/lib/display/display.c b/lib/display/display.c
index 36c9879..0a37630 100644
--- a/lib/display/display.c
+++ b/lib/display/display.c
@@ -399,7 +399,7 @@ int lvdisplay_full(struct cmd_context *cmd,
void *handle __attribute__((unused)))
{
struct lvinfo info;
- int inkernel, snap_active = 0;
+ int inkernel, snap_active = 0, partial = 0, raid0_partial = 0;
char uuid[64] __attribute__((aligned(8)));
const char *access_str;
struct lv_segment *snap_seg = NULL, *mirror_seg = NULL;
@@ -553,11 +553,17 @@ int lvdisplay_full(struct cmd_context *cmd,
log_print("LV VDO Pool name %s", seg_lv(seg, 0)->name);
}
+ if (lv_is_partial(lv)) {
+ partial = 1;
+ if (lv_is_raid(lv) && seg_is_any_raid0(first_seg(lv)))
+ raid0_partial = 1;
+ }
if (inkernel && info.suspended)
log_print("LV Status suspended");
else if (activation())
- log_print("LV Status %savailable",
- inkernel ? "" : "NOT ");
+ log_print("LV Status %savailable %s",
+ (inkernel && !raid0_partial) ? "" : "NOT ",
+ partial ? "(partial)" : "");
/********* FIXME lv_number
log_print("LV # %u", lv->lv_number + 1);
--
1.8.3.1
reply other threads:[~2020-08-22 2:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598063891-25553-1-git-send-email-heming.zhao@suse.com \
--to=heming.zhao@suse.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).