linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: bert hubert <ahu@ds9a.nl>
To: mauelsha@ez-darmstadt.telekom.de, linux-lvm@msede.com
Subject: [linux-lvm] [Patch] lvchange better error reporting
Date: Sat, 15 Apr 2000 20:35:15 +0200	[thread overview]
Message-ID: <20000415203514.A21662@home.ds9a.nl> (raw)

Heinz, people,

It annoyed me that lvchange sometimes reported that volume group "(null)"
was invalid. This patch fixes this behaviour. Please apply.

diff -u -r 0.8final.orig/tools/lvchange.c 0.8final/tools/lvchange.c
--- 0.8final.orig/tools/lvchange.c	Tue Feb 22 03:09:33 2000
+++ 0.8final/tools/lvchange.c	Sat Apr 15 20:32:34 2000
@@ -255,9 +255,15 @@
       /* does VG exist? */
       if ( opt_v > 0) printf ( "%s -- checking volume group existence\n", cmd);
       if ( lvm_tab_vg_check_exist ( vg_name, NULL) != TRUE) {
-         fprintf ( stderr, "%s -- can't change logical volume: volume group "
-                           "\"%s\" doesn't exist\n\n", cmd, vg_name);
-         return LVM_ELVCHANGE_VG_CHECK_EXIST;
+        
+         if(vg_name)
+            fprintf ( stderr, "%s -- can't change logical volume: volume group "
+                 "\"%s\" doesn't exist\n\n", cmd, vg_name);
+         else
+            fprintf ( stderr, "%s -- can't change logical volume: need to specify "
+                              "volume group\n\n", cmd);
+                              
+         return LVM_ELVCHANGE_VG_CHECK_EXIST;
       }
 
       if ( opt_v > 0) printf ( "%s -- checking for active volume "

-- 
                       |              http://www.rent-a-nerd.nl
                       |                     - U N I X -
                       |          Inspice et cautus eris - D11T'95

             reply	other threads:[~2000-04-15 18:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-04-15 18:35 bert hubert [this message]
2000-04-15 23:38 ` [linux-lvm] [Patch] lvchange better error reporting Christopher Briggs
2000-04-15 22:56   ` bert hubert
2000-04-19 19:50 ` Heinz Mauelshagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20000415203514.A21662@home.ds9a.nl \
    --to=ahu@ds9a.nl \
    --cc=linux-lvm@msede.com \
    --cc=mauelsha@ez-darmstadt.telekom.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).