linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
* [linux-lvm] [PATCH] Documentation/dm-init: fix multi device example
@ 2019-06-04 18:27 Helen Koike
  2019-06-04 19:37 ` Stephen Boyd
  2019-06-07 17:13 ` Jonathan Corbet
  0 siblings, 2 replies; 3+ messages in thread
From: Helen Koike @ 2019-06-04 18:27 UTC (permalink / raw)
  To: dm-devel, swboyd
  Cc: wad, keescook, snitzer, linux-doc, richard.weinberger,
	Jonathan Corbet, linux-kernel, Helen Koike, linux-lvm,
	enric.balletbo, kernel, agk

The example in the docs regarding multiple device-mappers is invalid (it
has a wrong number of arguments), it's a left over from previous
versions of the patch.
Replace the example with an valid and tested one.

Signed-off-by: Helen Koike <helen.koike@collabora.com>

---

 Documentation/device-mapper/dm-init.txt | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Documentation/device-mapper/dm-init.txt b/Documentation/device-mapper/dm-init.txt
index 8464ee7c01b8..130b3c3679c5 100644
--- a/Documentation/device-mapper/dm-init.txt
+++ b/Documentation/device-mapper/dm-init.txt
@@ -74,13 +74,13 @@ this target to /dev/mapper/lroot (depending on the rules). No uuid was assigned.
 An example of multiple device-mappers, with the dm-mod.create="..." contents is shown here
 split on multiple lines for readability:
 
-  vroot,,,ro,
-    0 1740800 verity 254:0 254:0 1740800 sha1
-      76e9be054b15884a9fa85973e9cb274c93afadb6
-      5b3549d54d6c7a3837b9b81ed72e49463a64c03680c47835bef94d768e5646fe;
-  vram,,,rw,
-    0 32768 linear 1:0 0,
-    32768 32768 linear 1:1 0
+  dm-linear,,1,rw,
+    0 32768 linear 8:1 0,
+    32768 1024000 linear 8:2 0;
+  dm-verity,,3,ro,
+    0 1638400 verity 1 /dev/sdc1 /dev/sdc2 4096 4096 204800 1 sha256
+    ac87db56303c9c1da433d7209b5a6ef3e4779df141200cbd7c157dcb8dd89c42
+    5ebfe87f7df3235b80a117ebc4078e44f55045487ad4a96581d1adb564615b51
 
 Other examples (per target):
 
-- 
2.20.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-lvm] [PATCH] Documentation/dm-init: fix multi device example
  2019-06-04 18:27 [linux-lvm] [PATCH] Documentation/dm-init: fix multi device example Helen Koike
@ 2019-06-04 19:37 ` Stephen Boyd
  2019-06-07 17:13 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2019-06-04 19:37 UTC (permalink / raw)
  To: Helen Koike, dm-devel
  Cc: wad, keescook, snitzer, linux-doc, richard.weinberger,
	Jonathan Corbet, linux-kernel, linux-lvm, enric.balletbo, kernel,
	agk

Quoting Helen Koike (2019-06-04 11:27:19)
> The example in the docs regarding multiple device-mappers is invalid (it
> has a wrong number of arguments), it's a left over from previous
> versions of the patch.
> Replace the example with an valid and tested one.
> 
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
> 
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-lvm] [PATCH] Documentation/dm-init: fix multi device example
  2019-06-04 18:27 [linux-lvm] [PATCH] Documentation/dm-init: fix multi device example Helen Koike
  2019-06-04 19:37 ` Stephen Boyd
@ 2019-06-07 17:13 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2019-06-07 17:13 UTC (permalink / raw)
  To: Helen Koike
  Cc: wad, keescook, snitzer, linux-doc, richard.weinberger,
	linux-kernel, swboyd, dm-devel, linux-lvm, enric.balletbo,
	kernel, agk

On Tue,  4 Jun 2019 15:27:19 -0300
Helen Koike <helen.koike@collabora.com> wrote:

> The example in the docs regarding multiple device-mappers is invalid (it
> has a wrong number of arguments), it's a left over from previous
> versions of the patch.
> Replace the example with an valid and tested one.
> 
> Signed-off-by: Helen Koike <helen.koike@collabora.com>

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-06-07 17:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 18:27 [linux-lvm] [PATCH] Documentation/dm-init: fix multi device example Helen Koike
2019-06-04 19:37 ` Stephen Boyd
2019-06-07 17:13 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).