From: David Teigland <teigland@redhat.com>
To: Heming Zhao <heming.zhao@suse.com>
Cc: Martin Wilck <mwilck@suse.de>,
LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] system boot time regression when using lvm2-2.03.05
Date: Fri, 6 Sep 2019 09:15:31 -0500 [thread overview]
Message-ID: <20190906141531.GC652@redhat.com> (raw)
In-Reply-To: <4552ae36-09fc-9145-d768-80b4ef572bca@suse.com>
On Fri, Sep 06, 2019 at 08:46:52AM +0000, Heming Zhao wrote:
> the core/key code for online lvs is _pvscan_aa():
> _pvscan_aa
> +-> _pvscan_aa_direct
> | vgchange_activate
> |
> or
> |
> +-> process_each_vg //this func can work without reading /run/lvm/pvs_online/xx
> _pvscan_aa_single
> vgchange_activate
>
> So my first patch partly backout commit 25b58310e3d6. To use process_each_vg active lvs, this func can work without reading /run/lvm/pvs_online/xx.
That commit is a couple days old, so there could still be a bug in there,
but I think it's a distraction. You reported this slowness prior to that
commit existing. You could revert it if it's causing questions.
I don't see much use in testing modified code until we've determined that
a given command is indeed slower when doing the same thing as before. If
you can do that, then collect the debug output from both old and new for
me to compare (-vvvv or lvm.conf file and verbose settings).
next prev parent reply other threads:[~2019-09-06 14:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 13:52 [linux-lvm] system boot time regression when using lvm2-2.03.05 Heming Zhao
2019-08-29 14:37 ` David Teigland
2019-09-03 5:02 ` Heming Zhao
2019-09-03 15:17 ` David Teigland
2019-09-04 8:13 ` Heming Zhao
2019-09-05 12:35 ` Heming Zhao
2019-09-05 16:55 ` David Teigland
2019-09-06 4:31 ` Heming Zhao
2019-09-06 5:01 ` Heming Zhao
2019-09-06 6:51 ` Martin Wilck
2019-09-06 8:46 ` Heming Zhao
2019-09-06 14:15 ` David Teigland [this message]
2019-09-06 14:26 ` David Teigland
2019-09-06 14:03 ` David Teigland
2019-09-09 11:42 ` Heming Zhao
2019-09-09 14:09 ` David Teigland
2019-09-10 8:01 ` Martin Wilck
2019-09-10 15:20 ` David Teigland
2019-09-10 20:38 ` Zdenek Kabelac
2019-09-11 7:17 ` Martin Wilck
2019-09-11 9:13 ` Zdenek Kabelac
2019-09-12 13:58 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906141531.GC652@redhat.com \
--to=teigland@redhat.com \
--cc=heming.zhao@suse.com \
--cc=linux-lvm@redhat.com \
--cc=mwilck@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).