linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Joe Thornber <thornber@redhat.com>
To: LVM general discussion and development <linux-lvm@redhat.com>
Cc: David Teigland <teigland@redhat.com>
Subject: Re: [linux-lvm] resend patch - bcache may mistakenly write data to another disk when writes error
Date: Tue, 29 Oct 2019 11:01:41 +0000	[thread overview]
Message-ID: <20191029110141.x6ct2n7ofhd34efw@reti> (raw)
In-Reply-To: <324885c4-a211-fb11-8315-979935391820@suse.com>

On Tue, Oct 29, 2019 at 05:07:30AM +0000, Heming Zhao wrote:
> Hello Joe,
> 
> Please check my comments for your commit 2938b4dcc & 6b0d969b
> 
> 1. b->ref_count is non-zero, and write error happens, the data never release?
>     (no place to call _unlink_block & _free_block)

Correct, the data will not be released until the client calls bcache_abort_fd(), to
indicate that it's giving up on the write.  That way the client is free to retry
io, eg, see this unit test:

 689│static void test_write_bad_issue_stops_flush(void *context)
   1│{
   2│        struct fixture *f = context;
   3│        struct mock_engine *me = f->me;
   4│        struct bcache *cache = f->cache;
   5│        struct block *b;
   6│        int fd = 17;
   7│ 
   8│        T_ASSERT(bcache_get(cache, fd, 0, GF_ZERO, &b));
   9│        _expect_write_bad_issue(me, fd, 0);
  10│        bcache_put(b);
  11│        T_ASSERT(!bcache_flush(cache));
  12│
  13│        // we'll let it succeed the second time
  14│        _expect_write(me, fd, 0);
  15│        _expect(me, E_WAIT);
  16│        T_ASSERT(bcache_flush(cache));
  17│}


> 2. when dev_write_bytes failed, call dev_unset_last_byte with "fd=-1" is wrong.

Quite possibly, this unset_last_byte stuff is a hack that Dave put in.  I'll look some more.


> 3. I still think below error handling should be added.
>     Below base on stable-2.02, but the core idea is same, should access the return value of io_submit & io_getevents.
>     
> ```
> static bool _async_issue(struct io_engine *ioe, enum dir d, int fd,
>     ... ...
>      if (r < 0) {
>          _cb_free(e->cbs, cb);
> +       ((struct block *)context)->error = r; <== assign errno & print warning
> +       log_warn("io_submit <%c> off %llu bytes %llu return %d:%s",
> +           (d == DIR_READ) ? 'R' : 'W', (long long unsigned)offset,
> +           (long long unsigned)nbytes, r, strerror(-r));
>          return false;
>      }
> 
> static void _issue_low_level(struct block *b, enum dir d)
>     ... ...
>      dm_list_move(&cache->io_pending, &b->list);
>   
>      if (!cache->engine->issue(cache->engine, d, b->fd, sb, se, b->data, b)) {
> -       /* FIXME: if io_submit() set an errno, return that instead of EIO? */
> -       _complete_io(b, -EIO);
> +       _complete_io(b, b->error); <=== this pass the right errno to caller.
>          return;
>      }
>   }

Yep, this is good. Added.


> -static void _wait_all(struct bcache *cache)
> +static bool _wait_all(struct bcache *cache) <=== change to return error
>   {
> +   bool ret = true;
>      while (!dm_list_empty(&cache->io_pending))
> -       _wait_io(cache);
> +       ret = _wait_io(cache);
> +   return ret;
>   }
>   
> -static void _wait_specific(struct block *b)
> +static bool _wait_specific(struct block *b) <=== change to return error
>   {
> +   bool ret = true;
>      while (_test_flags(b, BF_IO_PENDING))
> -       _wait_io(b->cache);
> +       ret = _wait_io(b->cache);
> +   return ret;
>   }

No, the wait functions just wait for io to complete, they're not interested
in whether it succeeded.  That's what b->error is for.


> 
>   bool bcache_flush(struct bcache *cache) <==== add more error handling
>   {
> +   bool write_ret = true, wait_ret = true;
>   
>      ... ...
>          _issue_write(b);
> +       if (b->error) write_ret = false;
>      }
>   
> -   _wait_all(cache);
> +   wait_ret = _wait_all(cache);
>   
> -   return dm_list_empty(&cache->errored);
> +   if (write_ret == false || wait_ret == false ||
> +           !dm_list_empty(&cache->errored))
> +       return false;
> +   else
> +       return true;
>   }

I don't understand how this changes the behaviour from just checking the
size of cache->errored.

- Joe

  parent reply	other threads:[~2019-10-29 11:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22  9:47 Heming Zhao
2019-10-23 21:31 ` Joe Thornber
2019-10-24  3:06   ` Heming Zhao
2019-10-28 15:43     ` Joe Thornber
2019-10-29  5:07       ` Heming Zhao
2019-10-29  9:46         ` Heming Zhao
2019-10-29 11:05           ` Joe Thornber
2019-10-29 11:47             ` Heming Zhao
2019-10-29 14:41               ` Joe Thornber
2019-10-29 11:01         ` Joe Thornber [this message]
2019-10-29 11:41           ` Heming Zhao
2019-10-24  3:13   ` Heming Zhao
2019-10-28  8:38     ` Heming Zhao
     [not found] <fc8ca0d7-23d9-8145-05e5-27a7ea2a7682@suse.com>
     [not found] ` <872328cd-3d51-97bb-1c50-b54cc194c6f2@suse.com>
2019-11-12 15:21   ` David Teigland
     [not found]     ` <667efc9f-1001-37cc-c0af-b352ff366c03@suse.com>
2019-11-13 15:41       ` David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029110141.x6ct2n7ofhd34efw@reti \
    --to=thornber@redhat.com \
    --cc=linux-lvm@redhat.com \
    --cc=teigland@redhat.com \
    --subject='Re: [linux-lvm] resend patch - bcache may mistakenly write data to another disk when writes error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).