From: "heming.zhao@suse.com" <heming.zhao@suse.com>
To: linux-lvm@redhat.com
Cc: teigland@redhat.com
Subject: [linux-lvm] commit c527a0cbfc3 may have a bug
Date: Fri, 14 Feb 2020 23:18:31 +0800 [thread overview]
Message-ID: <28bcae47-4657-8466-c1e2-0151d9ee9f1e@suse.com> (raw)
In-Reply-To: <098d6e8d-2d2c-5067-1435-eefd7e2d09bc@suse.com>
Hello list & David,
The stable-2.02 branch commit c527a0cbfc391645d30407d2 may intruduce a bug.
There is a new function label_scan_pvscan_all(), which uses
cmd->lvmetad_filter to create devices list for scan.
code:
```
label_scan_pvscan_all
if (!(iter = dev_iter_create(cmd->lvmetad_filter, 0)))
... ...
while ((dev = dev_iter_get(iter)))
... ...
```
It looks it is wrong to use cmd->lvmetad_filter in label_scan_pvscan_all.
The behaviour is changed after the patch applied. (legacy code use
cmd->full_filter)
When system has duplicated devices and startup, with patch c527a0cb, the
duplicated devs will pass global_filter (usually it's empty). It makes
lvmetad fail to build up LV, then the system boot failed. This case is
not my imagination, one of our customer met recently.
So I suggest to change the cmd->lvmetad_filter to cmd->full_filter in
label_scan_pvscan_all().
The steps to reproduce:
```
create a loop dev.
use this loop to create some mapper devs. (share the same loop dev)
pvcreate on these mapper devs
# this cmd will output warning msg.
pvscan --cache --config ' devices { filter = [ "r|/dev/loop0|" } '
# this cmd will not output warning msg.
pvscan --cache --config ' devices { filter = [ "a|/dev/loop0|" ]
global_filter = [ "r|/dev/loop0|" ] } '
```
Thanks.
next parent reply other threads:[~2020-02-14 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <098d6e8d-2d2c-5067-1435-eefd7e2d09bc@suse.com>
2020-02-14 15:18 ` heming.zhao [this message]
2020-02-14 19:11 ` [linux-lvm] commit c527a0cbfc3 may have a bug David Teigland
2020-02-14 19:34 ` Gionatan Danti
2020-02-14 20:40 ` David Teigland
2020-02-15 5:22 ` heming.zhao
2020-02-15 12:40 ` Zdenek Kabelac
2020-02-15 19:15 ` Gionatan Danti
2020-02-15 20:19 ` Zdenek Kabelac
2020-02-16 15:17 ` Gionatan Danti
2020-02-15 20:49 ` Chris Murphy
2020-02-16 15:28 ` Gionatan Danti
2020-02-15 19:07 ` Gionatan Danti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28bcae47-4657-8466-c1e2-0151d9ee9f1e@suse.com \
--to=heming.zhao@suse.com \
--cc=linux-lvm@redhat.com \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).