From: Zdenek Kabelac <zkabelac@redhat.com>
To: Heming Zhao <heming.zhao@suse.com>,
LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] It looks wrong for the timeout when lvm test running
Date: Tue, 10 Dec 2019 10:03:51 +0100 [thread overview]
Message-ID: <5e05b9df-c18b-64f9-6e4f-19f33ad01d1a@redhat.com> (raw)
In-Reply-To: <b554a2f4-5157-d2be-6a36-2ed9aa787e55@suse.com>
Dne 10. 12. 19 v 4:23 Heming Zhao napsal(a):
> Hello Zdenek,
>
> Thank you for your feedback.
> When I switched to ramdisk backend devices, the time consuming is about 9s.
>
> I raised this topic for there may have a bug in timeout related codes,
> not for why the snapshot-merge.sh costs too much time.
>
> The code in below overwrite silent_start when select() successfully return.
> ```
> if ( select( nfds, &set, NULL, NULL, &wait ) > 0 ) {
> silent_start = end; /* something happened */ <====== this line!
> io.sync( false );
> }
> ```
Hi
This is intentional - the idea of this 'timeout' is - that during the timeout
period there is no progress on output (i.e. for 180s there was nothing printed
- which likely means something got locked - there is also secondary limitation
on number of output lines - so if something is doing endless printing loop,
it's also catched before it fill all disk spaces on testing machine... -
hopefully this explains 'something happened' comment.
In general we don't have strict 'limit' for test length in time - although if
test takes 10 minutes - it's likely not what was intended - but we don't have
that rule on individual test time as speed often largely depends on machine
performance.
Zdenek
next prev parent reply other threads:[~2019-12-10 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 9:20 [linux-lvm] It looks wrong for the timeout when lvm test running Heming Zhao
2019-12-09 9:40 ` Zdenek Kabelac
2019-12-09 10:58 ` Heming Zhao
2019-12-09 11:36 ` Zdenek Kabelac
2019-12-10 3:23 ` Heming Zhao
2019-12-10 9:03 ` Zdenek Kabelac [this message]
2019-12-10 9:11 ` Heming Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e05b9df-c18b-64f9-6e4f-19f33ad01d1a@redhat.com \
--to=zkabelac@redhat.com \
--cc=heming.zhao@suse.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).