From: Zdenek Kabelac <firstname.lastname@example.org>
To: "Zhangyanfei (YF)" <email@example.com>,
Cc: "firstname.lastname@example.org" <email@example.com>,
Subject: Re: [linux-lvm] [dm-devel] dmsetup hangs forever
Date: Thu, 26 Oct 2017 10:39:19 +0200 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
Dne 26.10.2017 v 10:07 Zhangyanfei (YF) napsal(a):
> I find an issue when use �dmsetup in the situation udev event timeout.
> Dmsetup use the dm_udev_wait function sync with udev event.When use the
> dmsetup generate a new dm-disk, if the raw disk is abnormal(for example ,a
> ipsan disk hung IO request), the udevd daemon handle the dm-disk udev event
> maybe timeout, and will not notify the dmsetup �by semaphore. And because the
> �dm_udev_wait use the semop to sync with udevd, if udevd event timeout, the
> dmsetup will hung forever even when the raw disk be recovery.
> I wonder if we could use the semtimedop instead semop to add the timeout in
> function �dm_udev_wait. If the udevd daemon timeout when handle the dm event,
> the dm_udev_wait could timeout too, and the dmsetup could return error.
> This is my patch base lvm2-2.02.115-3:
Unfortunately the same argument why this can't really work still applies.
If the dm will start to timeout on it's own - without coordination with udev,
your system's logic will end-up with one big mess.
So if the dm would handle timeout - you would also need to provide mechanism
to correct associated services around it.
The main case here is - it's mandatory it's udev finalizing any timeouts so
it's in sync with db content.
Moreover if you start to timeout - you typically mask some system failure. In
majority of cases I've ever seen - it's been always a bug from this category
(buggy udev rule, or service). So it's always better to fix the bug then keep
AFAIK I'd like to see the semaphore to go away - but it needs wider cooperation.
next prev parent reply other threads:[~2017-10-26 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 8:07 [linux-lvm] dmsetup hangs forever Zhangyanfei (YF)
2017-10-26 8:39 ` Zdenek Kabelac [this message]
2017-10-27 8:00 ` [linux-lvm] 答复: [dm-devel] " Zhangyanfei (YF)
2017-10-27 12:28 ` Zdenek Kabelac
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).