linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Peter Rajnoha <prajnoha@redhat.com>
To: waldi@debian.org
Cc: linux-lvm@redhat.com
Subject: Re: [linux-lvm] systemd generator fails if lvmconfig does not find a value
Date: Thu, 3 Jan 2019 12:42:08 +0100	[thread overview]
Message-ID: <77607f5c-1909-f062-2c38-23872e91c89f@redhat.com> (raw)
In-Reply-To: <20181223185731.ddtmh3wqsrvx5kug@shell.thinkmo.de>

On 12/23/18 7:57 PM, Bastian Blank wrote:
> Moin
> 
> The systemd generator in 2.03.01 fails if the config does not yet
> contain the variables it tries to read via lvmconfig.  It aborts as
> lvmconfig exits with exit value 5.
> 
> | % /sbin/lvmconfig config/checks te/t 2>/dev/null; echo $? 
> | checks=1
> | 5
> 
> As generators should not fail, ignoring lvmconfig problems might be the
> best option.  The fallback of just generating services is safe.

We could probably use "lvmconfig --type full" here instead. The "--type
full" will get the actual setting if it exists and if not, it'll take
the default value. And yes, even if that one fails, we should still
generate the services... Thanks for noticing! I'll patch this.

-- 
Peter

      reply	other threads:[~2019-01-03 11:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23 18:57 [linux-lvm] systemd generator fails if lvmconfig does not find a value Bastian Blank
2019-01-03 11:42 ` Peter Rajnoha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77607f5c-1909-f062-2c38-23872e91c89f@redhat.com \
    --to=prajnoha@redhat.com \
    --cc=linux-lvm@redhat.com \
    --cc=waldi@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).