From: "heming.zhao@suse.com" <heming.zhao@suse.com>
To: linux-lvm@redhat.com
Subject: [linux-lvm] issue (or bug): when vgremove does removing lvmcache
Date: Sat, 23 May 2020 22:03:50 +0800 [thread overview]
Message-ID: <7a26b791-9739-d6dc-1744-7471f3c00af8@suse.com> (raw)
Hello List,
when using below reproduced steps, lvm command show error info.
```
# pvcreate /dev/sda /dev/sdb
# vgcreate test /dev/sda /dev/sdb
# lvcreate --name main --size 200m test /dev/sda
# lvcreate --name fast --size 50m test /dev/sdb
# lvconvert -y --type cache --cachevol fast test/main
# lvs -a -o name,vgname,lvattr,origin,segtype,devices test
LV VG Attr Origin Type Devices
[fast] test Cwi-aoC--- linear /dev/sdb(0)
main test Cwi-a-C--- [main_corig] cache main_corig(0)
[main_corig] test owi-aoC--- linear /dev/sda(0)
# vgremove test --force
Logical volume "main" successfully removed
Assertion failed: can't _pv_write non-orphan PV (in VG )
Failed to remove physical volume "/dev/sdb" from volume group "test"
Volume group "test" not properly removed
# lvs # <== output none
# vgs # <== output none
# pvs
WARNING: PV /dev/sdb is marked in use but no VG was found using it.
WARNING: PV /dev/sdb might need repairing.
PV VG Fmt Attr PSize PFree
/dev/sda lvm2 --- 300.00m 300.00m
/dev/sdb [unknown] lvm2 u-- 300.00m 0
```
rootcause analysis:
1>
why output: Assertion failed: can't _pv_write non-orphan PV (in VG )
_vgremove_single
vg_remove
vg_remove_direct
pv_write(vg->cmd, pv, 0)
pv_write
if (!allow_non_orphan &&
(!is_orphan_vg(pv->vg_name) || pv->pe_alloc_count)) {
log_error("Assertion failed: can't _pv_write non-orphan PV "
"(in VG %s)", pv_vg_name(pv));
return 0;
}
the pv->pe_alloc_count is non-zero.
2>
why pv->pe_alloc_count is non-zero.
_vgremove_single
process_each_lv_in_vg
/*
* Only let hidden LVs through if --all was used or the LVs
* were specifically named on the command line.
*/
if (!lvargs_supplied && !lv_is_visible(lvl->lv) && !arg_is_set(cmd, all_ARG) &&
(!cmd->process_component_lvs || !lv_is_component(lvl->lv)))
continue;
cmd->process_component_lvs and lv_is_component(lvl->lv) are false,
then lv can't join in final_lvl and won't be removed later.
At last,
I can't find a good solution for this issue. the 112846ce0b01e5353 introduced this issue.
one solution maybe to add CACHE_POOL_METADATA in lv->status when _read_lvnames constructs lv.
Thanks.
next reply other threads:[~2020-05-23 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 14:03 heming.zhao [this message]
2020-05-26 21:30 ` [linux-lvm] issue (or bug): when vgremove does removing lvmcache David Teigland
2020-05-27 2:57 ` heming.zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a26b791-9739-d6dc-1744-7471f3c00af8@suse.com \
--to=heming.zhao@suse.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).