linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Ming-Hung Tsai <mingnus@gmail.com>
To: linux-lvm@redhat.com
Subject: [linux-lvm] LVM doesn't resume the origin if it failed to take a dm-thin snapshot
Date: Thu, 21 Dec 2017 12:13:38 +0800	[thread overview]
Message-ID: <CAAYit8R_xCvhiZQo81FxJzoXkc1q7T6iBTH0C61MrLwZOb2ZwA@mail.gmail.com> (raw)

The function lv_create_an_lv() returns immediately if the callee
suspend_lv_origin() was failed, thus the origin remains suspended in
the end. It's possible to happen when we are taking snapshot while the
pool is in READ_ONLY mode (i.e., metadata needs_check flag was set).

Why it doesn't resume the origin no matter suspend_lv_origin() was
failed or not, like update_pool_lv(), so that users don't need to do
manual inversion?


Thanks,
Ming-Hung Tsai

                 reply	other threads:[~2017-12-21  4:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAYit8R_xCvhiZQo81FxJzoXkc1q7T6iBTH0C61MrLwZOb2ZwA@mail.gmail.com \
    --to=mingnus@gmail.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).