linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Mark Mielke <mark.mielke@gmail.com>
To: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] Why isn't issue_discards enabled by default?
Date: Mon, 21 Sep 2020 10:26:41 -0400	[thread overview]
Message-ID: <CALm7yL3rOuRsc=Cvw4P9+o-1crU8B_9dDwgDiSwthhgBKuX5YQ@mail.gmail.com> (raw)
In-Reply-To: <4972578.pTZnC5dHRY@walnut>

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

On Mon, Sep 21, 2020 at 10:14 AM nl6720 <nl6720@gmail.com> wrote:

> I wanted to know why the "issue_discards" setting isn't enabled by
> default. Are there any dangers in enabling it or if not is there a
> chance of getting the default changed?
>
> Also it's not entirely clear to me if/how "issue_discards" affects thin
> pool discard passdown.
>

Historically, there have been dangers. Even today, there might still be
dangers - although, I believe Linux (and other OS) may disable the feature
in hardware which is known to behave improperly.

If you do research and ensure you are using a good storage drive, there
should not be any problems. I enable issue_discards on all systems I work
with at home and work, and have not encountered any problems. But, I also
don't buy cheap drives with questionable namebrands.

It's pretty common for settings such as these to be more conservative, to
ensure that the users who are willing to accept the risk (no matter how
small) can turn it on as an option, and the users who are unaware or might
not have evaluated the risk, cannot blame the software vendors for losing
their data. In the case of LVM - it's not LVM's fault that some drives
might lose your data when discard is sent. But, users of LVM might blame
LVM.

-- 
Mark Mielke <mark.mielke@gmail.com>

[-- Attachment #2: Type: text/html, Size: 1829 bytes --]

  reply	other threads:[~2020-09-21 14:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 14:14 nl6720
2020-09-21 14:26 ` Mark Mielke [this message]
2020-09-22  8:13   ` Zdenek Kabelac
2020-09-21 18:51 ` Zdenek Kabelac
2020-09-22  9:14   ` nl6720
2020-09-22  9:20     ` nl6720
2020-09-22 10:15     ` Zdenek Kabelac
2020-09-22 10:38       ` nl6720
2020-09-22 10:59         ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALm7yL3rOuRsc=Cvw4P9+o-1crU8B_9dDwgDiSwthhgBKuX5YQ@mail.gmail.com' \
    --to=mark.mielke@gmail.com \
    --cc=linux-lvm@redhat.com \
    --subject='Re: [linux-lvm] Why isn'\''t issue_discards enabled by default?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).