linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Gang He <GHe@suse.com>
To: David Teigland <teigland@redhat.com>
Cc: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] can we change cluster_ringid_seq in libdlm from uint32_t to uint64_t?
Date: Fri, 15 May 2020 07:42:16 +0000	[thread overview]
Message-ID: <CH2PR18MB3206236312047FF9317ECD22CFBD0@CH2PR18MB3206.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20200427150341.GA27631@redhat.com>

Hi David,

I did some testing with this patch.
It looks OK. Do you plan to commit the patch into the git tree?


Thanks
Gang

> -----Original Message-----
> From: David Teigland [mailto:teigland@redhat.com]
> Sent: 2020��4��27�� 23:04
> To: Gang He <GHe@suse.com>
> Cc: LVM general discussion and development <linux-lvm@redhat.com>
> Subject: Re: [linux-lvm] can we change cluster_ringid_seq in libdlm from
> uint32_t to uint64_t?
> 
> On Sun, Apr 26, 2020 at 07:24:33AM +0000, Gang He wrote:
> > Hello List,
> >
> > In libdlm code, cluster_ringid_seq variable is defined with uint32_t
> > in dlm_controld/dlm_daemon.h, the corosync API returns uinit64_t ring_id,
> in the current code, we use type cast to get the low-32bit ring-id.
> > But, in some case, the corosync returns a huge ring-id (greater than 32bit),
> the DLM daemon does not work normally (looks stuck).
> > Then, I want to know if we can change cluster_ringid_seq in libdlm from
> uint32_t to uint64_t?
> 
> That looks ok, please try the attached patch.
> Dave

      reply	other threads:[~2020-05-15  7:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26  7:24 [linux-lvm] can we change cluster_ringid_seq in libdlm from uint32_t to uint64_t? Gang He
2020-04-27 15:03 ` David Teigland
2020-05-15  7:42   ` Gang He [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR18MB3206236312047FF9317ECD22CFBD0@CH2PR18MB3206.namprd18.prod.outlook.com \
    --to=ghe@suse.com \
    --cc=linux-lvm@redhat.com \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).