From mboxrd@z Thu Jan 1 00:00:00 1970 References: <20200106104857.0fa111e4@leda> From: Zdenek Kabelac Message-ID: Date: Mon, 6 Jan 2020 12:24:56 +0100 MIME-Version: 1.0 In-Reply-To: <20200106104857.0fa111e4@leda> Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [linux-lvm] bashism in tools/Makefile.in Reply-To: LVM general discussion and development List-Id: LVM general discussion and development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: LVM general discussion and development , Christian Hesse Dne 06. 01. 20 v 10:48 Christian Hesse napsal(a): > Hello everybody, > > building lvm2 with a shell other than bash fails: > > % make -C tools/ command-count.h > make: Entering directory 'lvm2/tools' > [GEN] cmds.h > /bin/dash: 1: set: Illegal option -o pipefail > [GEN] command-lines-input.h > /bin/dash: 1: set: Illegal option -o pipefail > [GEN] command-count.h > /bin/dash: 1: set: Illegal option -o pipefail > make: *** [Makefile:170: command-count.h] Error 2 > make: Leaving directory 'lvm2/tools' > > Please fix bashism in Makefile. Thanks! > Hi Unfortunately whole lvm2 project is mostly 'bash' based and all developers mostly use bash - so we would welcome patches if they would provide equivalently working code without bashism... Fixing couple things while the whole rest of project is still requiring bash doesn't make it any better - ATM all scripts/tests/Makefiles mostly expect presence of bash. Regards Zdenek