From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0000DCF619 for ; Wed, 12 Aug 2020 13:32:55 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3529108C26C for ; Wed, 12 Aug 2020 13:32:54 +0000 (UTC) References: <1597231111-28086-1-git-send-email-heming.zhao@suse.com> From: "heming.zhao@suse.com" Message-ID: Date: Wed, 12 Aug 2020 21:32:40 +0800 In-Reply-To: <1597231111-28086-1-git-send-email-heming.zhao@suse.com> Content-Language: en-US MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [linux-lvm] [PATCH] tests: use correct RA size, underly dev & delay time. Reply-To: LVM general discussion and development List-Id: LVM general discussion and development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Content-Type: text/plain; charset="us-ascii" To: linux-lvm@redhat.com a little more info about my patch. in one of my test env, system default read_ahead size is 1024 sector (512K), which bigger than 128k in test case. which causes _set_dev_node_read_ahead() to deny to set up RA. On 8/12/20 7:18 PM, Zhao Heming wrote: > lvconvert-repair-raid.sh: > - in some env, the delay=0 is too short to set up env. > > lvcreate-usage.sh: > - use correct underlying dev for brd & loop devices. > - read ahead size should equal or bigger than current system value > > read-ahead.sh: > - use current system ra_size PLUS 128 to set up new ra_size. > for detail, refer _set_dev_node_read_ahead in libdm-common.c > > Signed-off-by: Zhao Heming > --- > test/shell/lvconvert-repair-raid.sh | 2 +- > test/shell/lvcreate-usage.sh | 11 ++++++----- > test/shell/read-ahead.sh | 6 ++++-- > 3 files changed, 11 insertions(+), 8 deletions(-) >