From: "heming.zhao@suse.com" <heming.zhao@suse.com>
To: linux-lvm@redhat.com
Subject: Re: [linux-lvm] [PATCH] lvdisplay: dispaly partial when underlying devs missing
Date: Wed, 19 Aug 2020 12:39:19 +0800 [thread overview]
Message-ID: <ddc09a43-3aba-b290-9c37-d2d8cf94ef43@suse.com> (raw)
In-Reply-To: <1597810558-23809-1-git-send-email-heming.zhao@suse.com>
I'm not sure whether in any case one of the LV underlying dev missing must think as 'not available (partial)'.
if a LV contains 10 PVs, and the rear PVs haven't be used. in this case display 'available (partial)' looks better
than 'not available (partial)'. but anyway, the 'partial' should be displayed.
On 8/19/20 12:15 PM, Zhao Heming wrote:
> After removing LV underlying dev, lvdisplay still display 'available'.
>
> With this patch, lvdisplay will show
> from:
> LV Status available
> to:
> LV Status NOT available (partial)
>
> reproducible steps:
> 1. vgcreate vg1 /dev/sda /dev/sdb
> 2. lvcreate --type raid0 -l 100%FREE -n raid0lv vg1
> 3. do remove the /dev/sdb action
> 4. lvdisplay show wrong 'LV Status'
>
> Signed-off-by: Zhao Heming <heming.zhao@suse.com>
> ---
> lib/display/display.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/lib/display/display.c b/lib/display/display.c
> index 36c9879b3..6c895c820 100644
> --- a/lib/display/display.c
> +++ b/lib/display/display.c
> @@ -399,7 +399,7 @@ int lvdisplay_full(struct cmd_context *cmd,
> void *handle __attribute__((unused)))
> {
> struct lvinfo info;
> - int inkernel, snap_active = 0;
> + int inkernel, snap_active = 0, partial = 0;
> char uuid[64] __attribute__((aligned(8)));
> const char *access_str;
> struct lv_segment *snap_seg = NULL, *mirror_seg = NULL;
> @@ -555,9 +555,13 @@ int lvdisplay_full(struct cmd_context *cmd,
>
> if (inkernel && info.suspended)
> log_print("LV Status suspended");
> - else if (activation())
> - log_print("LV Status %savailable",
> - inkernel ? "" : "NOT ");
> + else if (activation()) {
> + if (lv->status & PARTIAL_LV)
> + partial = 1;
> + log_print("LV Status %savailable %s",
> + (inkernel && !partial) ? "" : "NOT ",
> + partial ? "(partial)" : "");
> + }
>
> /********* FIXME lv_number
> log_print("LV # %u", lv->lv_number + 1);
>
prev parent reply other threads:[~2020-08-19 4:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 4:15 [linux-lvm] [PATCH] lvdisplay: dispaly partial when underlying devs missing Zhao Heming
2020-08-19 4:39 ` heming.zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddc09a43-3aba-b290-9c37-d2d8cf94ef43@suse.com \
--to=heming.zhao@suse.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).