linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: David Teigland <teigland@redhat.com>
Cc: linux-lvm@redhat.com
Subject: Re: [linux-lvm] Frequent crashes when accessing dev_name(dev) on an empty list
Date: Mon, 21 Feb 2022 20:35:07 +0300	[thread overview]
Message-ID: <de77c4550787b0e9430d7e3cf0035c176df17722.camel@yandex.ru> (raw)
In-Reply-To: <20220221164947.GA18428@redhat.com>

On Mon, 2022-02-21 at 10:49 -0600, David Teigland wrote:
> On Mon, Feb 21, 2022 at 04:45:51PM +0300, Konstantin Kharlamov wrote:
> > So, what happened was that dev_name(dev) was extracting a `dev->aliases`
> > element
> > , however `dev->aliases` was empty, thus the extracted element was a junk.
> > 
> > Although we encountered these crashes on an older 2.03.07 version, however
> > the
> > patch applies to latest master as well, thus the bugs are still relevant,
> > which
> > is odd. This makes me wondering, is this a known problem, could I possibly
> > overlooked something, for example that dev->aliases should never be empty,
> > and
> > thus the fix just works around another problem? Any thoughts?
> 
> It's familiar, but I thought it was fixed.  I don't remember the details,
> so we'll have to look at it again.  It's related to a device being removed
> from the system while the command is running, which we need to add tests
> for.

Okay, thank you, so I guess the conclusion is that before anything else we need to reproduce it with the latest version.


_______________________________________________
linux-lvm mailing list
linux-lvm@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-lvm
read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/

  reply	other threads:[~2022-02-21 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 13:45 Konstantin Kharlamov
2022-02-21 16:49 ` David Teigland
2022-02-21 17:35   ` Konstantin Kharlamov [this message]
2022-04-01 14:48 ` Konstantin Kharlamov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de77c4550787b0e9430d7e3cf0035c176df17722.camel@yandex.ru \
    --to=hi-angel@yandex.ru \
    --cc=linux-lvm@redhat.com \
    --cc=teigland@redhat.com \
    --subject='Re: [linux-lvm] Frequent crashes when accessing dev_name(dev) on an empty list' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).