linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: matthew patton <pattonme@yahoo.com>,
	LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] lvm filter regex format
Date: Mon, 18 Dec 2017 23:43:57 +0100	[thread overview]
Message-ID: <eab88709-2581-97b7-707b-8423022670b1@redhat.com> (raw)
In-Reply-To: <72381975.739900.1513623186634@mail.yahoo.com>

Dne 18.12.2017 v 19:53 matthew patton napsal(a):
>>     https://github.com/jthornber/lvm2-ejt/blob/master/libdm/regex/parse_rx.h
>   
> not to be ungrateful but why on earth would one NOT use the glibc standard regex library? Nobody cares about pointless optimization. Surprises like "well, we only implemented most of the spec" are what drives people nuts!
> 
> I agree this particular length-based match is rather odd but there are plenty of useful examples I am sure that could benefit from {x,y} notation.


Such code was actually written long time ago - but since the syntax of 
standard glibc  regex accepts slightly different strings - it would be an 
incompatible change - so it's been considered now worth breaking the 
compatibility at that time...


Regards

Zdenek

  reply	other threads:[~2017-12-18 22:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <72381975.739900.1513623186634.ref@mail.yahoo.com>
2017-12-18 18:53 ` [linux-lvm] lvm filter regex format matthew patton
2017-12-18 22:43   ` Zdenek Kabelac [this message]
2017-12-19  8:51   ` Joe Thornber
2017-12-18 17:16 Thanos Makatos
2017-12-18 17:49 ` Joe Thornber
2017-12-19  9:36   ` Thanos Makatos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eab88709-2581-97b7-707b-8423022670b1@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=linux-lvm@redhat.com \
    --cc=pattonme@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).