From: Michael Schmitz <schmitzmic@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Cc: linux-m68k@vger.kernel.org, chzigotzky@xenosoft.de,
geert@linux-m68k.org, hch@lst.de, martin@lichtvoll.de,
stable@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v4 1/1] block: bugfix for Amiga partition overflow check patch
Date: Thu, 6 Jul 2023 10:09:50 +1200 [thread overview]
Message-ID: <01cf1491-a9b3-2342-3fd6-f4cae212bc43@gmail.com> (raw)
In-Reply-To: <f61ba21f-a8a0-756c-2a41-b831a0302395@kernel.dk>
Hi Jens,
On 6/07/23 09:44, Jens Axboe wrote:
> On 7/5/23 3:41?PM, Michael Schmitz wrote:
>> Hi Jens,
>>
>> On 6/07/23 08:42, Jens Axboe wrote:
>>> On 7/4/23 5:38?PM, Michael Schmitz wrote:
>>>> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
>>>> Fixes: b6f3f28f60 ("block: add overflow checks for Amiga partition support")
>>>> Cc: <stable@vger.kernel.org> # 5.2
>>> This is confusing - it's being marked for stable, but also labeled as
>>> fixing a commit that isn't even a release yet?
>> True - but as you had pointed out, the commit this fixes is set in
>> stone. How do we ensure this bugfix is picked up as well when the
>> other patches are backported? Does that happen automatically, or do I
>> need to add a Link: tag to the patch being fixed?
> This:
>
> Cc: <stable@vger.kernel.org> # 5.2
>
> should be enough for it to go into stable from 5.2 and onwards.
OK - I wasn't certain whether you wanted the Fixes or stable tag dropped.
>> (Greg didn't seem to object to the Fixes: as such, just to the
>> incorrect version prereq)
> I think it's really confusing... A patch should only have a Fixes tag if
> it's fixing a specific bug in that patch. Either it is, in which case
> you would not need Cc stable at all since it's only in 6.5-rc, or it
It is fixing a bug in b6f3f28f60. I should have checked whether the
patch series had already gone to release, not just -rc, instead of just
adding the stable tag out of caution.
> isn't and you should just have the stable tag with 5.2+ as you already
> have.
>
> I'll apply this and remove the Fixes line, and the message id thing
> too.
Thanks - whatever is least confusing is fine, as long as it's backported
to stable in the end.
Won't be sending v5 then...
Cheers,
Michael
next prev parent reply other threads:[~2023-07-05 22:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 20:17 [PATCH v13 0/3] Amiga RDB partition support fixes Michael Schmitz
2023-06-20 20:17 ` [PATCH v13 1/3] block: fix signed int overflow in Amiga partition support Michael Schmitz
2023-06-20 20:17 ` [PATCH v13 2/3] block: change all __u32 annotations to __be32 in affs_hardblocks.h Michael Schmitz
2023-06-20 20:17 ` [PATCH v13 3/3] block: add overflow checks for Amiga partition support Michael Schmitz
2023-06-20 20:28 ` [PATCH v13 0/3] Amiga RDB partition support fixes Jens Axboe
2023-06-20 21:16 ` Martin Steigerwald
2023-06-21 5:54 ` John Paul Adrian Glaubitz
2023-06-20 21:17 ` Michael Schmitz
2023-07-04 23:38 ` [PATCH v4 0/1] Bugfix for Amiga partition fixes Michael Schmitz
2023-07-04 23:38 ` [PATCH v4 1/1] block: bugfix for Amiga partition overflow check patch Michael Schmitz
2023-07-05 7:28 ` Geert Uytterhoeven
2023-07-05 8:53 ` Michael Schmitz
2023-07-05 9:08 ` Geert Uytterhoeven
2023-07-05 19:25 ` Michael Schmitz
2023-07-05 20:42 ` Jens Axboe
2023-07-05 21:41 ` Michael Schmitz
2023-07-05 21:44 ` Jens Axboe
2023-07-05 22:09 ` Michael Schmitz [this message]
2023-07-05 22:13 ` Jens Axboe
2023-07-05 22:25 ` Michael Schmitz
2023-07-05 22:34 ` Jens Axboe
2023-07-05 22:38 ` Jens Axboe
2023-07-05 23:54 ` Michael Schmitz
2023-07-06 7:23 ` Martin Steigerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01cf1491-a9b3-2342-3fd6-f4cae212bc43@gmail.com \
--to=schmitzmic@gmail.com \
--cc=axboe@kernel.dk \
--cc=chzigotzky@xenosoft.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=martin@lichtvoll.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).