From mboxrd@z Thu Jan 1 00:00:00 1970 From: Max Staudt Subject: Re: [PATCH] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Date: Tue, 13 Aug 2019 00:21:03 +0200 Message-ID: <0d61e12f-5fc5-7cb6-755f-298ebf4c935f@enpas.org> References: <20190811043253.24938-1-max@enpas.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Linux I2C , Wolfram Sang , Linux/m68k , Linux Kernel Mailing List , John Paul Adrian Glaubitz List-Id: linux-m68k@vger.kernel.org On 08/12/2019 11:37 AM, Geert Uytterhoeven wrote: >> + iowrite8(val, address); > > As this is on a Zorro bus, z_writeb()? I forgot to ask about this. What is the reasoning behind having a separate z_writeb() for Zorro? As far as I can see in arch/m68k/include/asm this maps 1:1 to a direct memory access, and it prohibits cross-arch code as in i2c-elektor. Thanks, Max