Linux-m68k Archive on
 help / color / Atom feed
From: "Gustavo A. R. Silva" <>
To: Geert Uytterhoeven <>,
	"Gustavo A. R. Silva" <>
Subject: [PATCH 2/2][next] m68k: amiga: config: Mark expected switch fall-through
Date: Thu, 26 Mar 2020 18:29:09 -0500
Message-ID: <> (raw)
In-Reply-To: <>

Mark switch cases where we are expecting to fall through.

This patch fixes the following warning (Building: allmodconfig m68k):

arch/m68k/amiga/config.c: In function ‘amiga_identify’:
./arch/m68k/include/asm/amigahw.h:42:50: warning: this statement may fall through [-Wimplicit-fallthrough=]
 #define AMIGAHW_SET(name) ( = 1)
arch/m68k/amiga/config.c:223:3: note: in expansion of macro ‘AMIGAHW_SET’
arch/m68k/amiga/config.c:224:2: note: here
  case AMI_500:

Replace the existing /* fall through */ comments and fix the issue above
by using the new pseudo-keyword fallthrough;

Signed-off-by: Gustavo A. R. Silva <>
 arch/m68k/amiga/config.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/m68k/amiga/config.c b/arch/m68k/amiga/config.c
index 06c15374200e..4eb911d64e8d 100644
--- a/arch/m68k/amiga/config.c
+++ b/arch/m68k/amiga/config.c
@@ -221,6 +221,7 @@ static void __init amiga_identify(void)
 	case AMI_1200:
+		fallthrough;
 	case AMI_500:
 	case AMI_500PLUS:
 	case AMI_1000:
@@ -233,7 +234,7 @@ static void __init amiga_identify(void)
 	case AMI_3000T:
-		/* fall through */
+		fallthrough;
 	case AMI_3000PLUS:
@@ -242,7 +243,7 @@ static void __init amiga_identify(void)
 	case AMI_4000T:
-		/* fall through */
+		fallthrough;
 	case AMI_4000:

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 23:23 [PATCH 0/2][next] m68k: amiga: config: Use flexible-array member and mark " Gustavo A. R. Silva
2020-03-26 23:29 ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-m68k Archive on

Archives are clonable:
	git clone --mirror linux-m68k/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-m68k linux-m68k/ \
	public-inbox-index linux-m68k

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone