From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A347DC433EB for ; Mon, 27 Jul 2020 07:26:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81DE32075D for ; Mon, 27 Jul 2020 07:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbgG0H04 (ORCPT ); Mon, 27 Jul 2020 03:26:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726968AbgG0H0u (ORCPT ); Mon, 27 Jul 2020 03:26:50 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A7BEC0619D2 for ; Mon, 27 Jul 2020 00:26:50 -0700 (PDT) Received: by ozlabs.org (Postfix, from userid 1034) id 4BFWZw3Xqrz9sTV; Mon, 27 Jul 2020 17:26:48 +1000 (AEST) From: Michael Ellerman To: Finn Thain , Benjamin Herrenschmidt Cc: Mark Cave-Ayland , Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Joshua Thompson , linuxppc-dev@lists.ozlabs.org, Laurent Vivier , linux-kernel@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH 0/9] Macintosh II ADB driver fixes Message-Id: <159583478319.602200.6930356633424802467.b4-ty@ellerman.id.au> Date: Mon, 27 Jul 2020 17:26:48 +1000 (AEST) Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Sun, 28 Jun 2020 14:23:12 +1000, Finn Thain wrote: > Various issues with the via-macii driver have become apparent over the > years. Some examples: > > - A Talk command response can be lost. This can result in phantom devices > being probed or an incorrect device handler ID being retrieved. > > - A reply packet containing a null byte can get truncated. Such packets > are sometimes generated by ADB keyboards. > > [...] Applied to powerpc/next. [1/9] macintosh/via-macii: Access autopoll_devs when inside lock https://git.kernel.org/powerpc/c/59ea38f6b3af5636edf541768a1ed721eeaca99e [2/9] macintosh/via-macii: Poll the device most likely to respond https://git.kernel.org/powerpc/c/f93bfeb55255bddaa16597e187a99ae6131b964a [3/9] macintosh/via-macii: Handle /CTLR_IRQ signal correctly https://git.kernel.org/powerpc/c/b4d76c28eca369b8105fe3a0a9f396e3fbcd0dd5 [4/9] macintosh/via-macii: Remove read_done state https://git.kernel.org/powerpc/c/b16b67689baa01a5616b651356df7ad3e47a8763 [5/9] macintosh/via-macii: Handle poll replies correctly https://git.kernel.org/powerpc/c/624cf5b538b507293ec761797bd8ce0702fefe64 [6/9] macintosh/via-macii: Use bool type for reading_reply variable https://git.kernel.org/powerpc/c/f87a162572c9f7c839a207c7de6c73ffe54a777c [7/9] macintosh/via-macii: Use unsigned type for autopoll_devs variable https://git.kernel.org/powerpc/c/5c0c15a1953a7de2878d7e6f5711fd3322b11faa [8/9] macintosh/via-macii: Use the stack for reset request storage https://git.kernel.org/powerpc/c/046ace8256489f32740da07de55a913ca09ce5cf [9/9] macintosh/via-macii: Clarify definition of macii_init() https://git.kernel.org/powerpc/c/3327e58a04501e06aa531cdb4044aab214a6254a cheers