linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: schmitzmic@gmail.com
Cc: alex@kazik.de, netdev@vger.kernel.org,
	linux-m68k@vger.kernel.org, rolf.anders@physik.uni-augsburg.de
Subject: Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support
Date: Fri, 28 Dec 2018 12:43:30 -0800 (PST)	[thread overview]
Message-ID: <20181228.124330.1798799446491889384.davem@davemloft.net> (raw)
In-Reply-To: <2a960bfa-000a-eb14-814b-476da5c1f5df@gmail.com>

From: Michael Schmitz <schmitzmic@gmail.com>
Date: Sat, 22 Dec 2018 10:30:58 +1300

> Am 21.12.2018 um 13:10 schrieb David Miller:
>> And in particular this huge complicated Kconfig construct is not
>> maintainable at all.
> 
> We can trim this down a bit (for reasons I've outlined before):
> 
> +if APNE
> +config APNE100MBIT
> +	bool "PCMCIA NE2000 100MBit support"
> +	default n
> +	depends on NE2000=n && PCMCIA_AXNET=n
> +	depends on PCMCIA_PCNET=n && STNIC=n && ULTRA=n && WD80x3=n
> 
> In all honesty, I doubt anyone could ever use the stnic, ultra and wd
> drivers on m68k (Geert?) so these could be omitted as well. Not sure
> pcnet_cs or axnet_cs are possible to use on the Amiga PCMCIA slot, so
> all that remains in practice is the ne driver (which is used on
> Atari).
> 
> Still too ugly?

I'm sorry, maybe I didn't express my concern clearly.

Any sizable list of exceptions in a Kconfig conditional has long term
maintainence costs.  If, for some reason, a new variant of support
for this chip arrives there will be a new Kconfig setting that would
need to be added here to your expressions.

That is insanely error prone, and I can guarantee it will get missed.

Having so many front end drivers for a chipset should be done in a
more modular manner, so that in fact they could all coexist if
necessary.

  reply	other threads:[~2018-12-28 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 22:24 [PATCH net-next] Amiga PCMCIA 100 MBit card support ALeX Kazik
2018-12-21  0:10 ` David Miller
2018-12-21 21:30   ` Michael Schmitz
2018-12-28 20:43     ` David Miller [this message]
2018-12-31  9:48       ` Michael Schmitz
2018-12-31 10:47         ` Andrew Lunn
2019-01-04  0:41           ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181228.124330.1798799446491889384.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alex@kazik.de \
    --cc=linux-m68k@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rolf.anders@physik.uni-augsburg.de \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).