From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45755CA9ECF for ; Mon, 4 Nov 2019 09:50:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E076921D7D for ; Mon, 4 Nov 2019 09:50:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="ReXeIcii" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728064AbfKDJuG (ORCPT ); Mon, 4 Nov 2019 04:50:06 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36585 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbfKDJuG (ORCPT ); Mon, 4 Nov 2019 04:50:06 -0500 Received: by mail-wr1-f65.google.com with SMTP id w18so16250617wrt.3 for ; Mon, 04 Nov 2019 01:50:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=zkMcvSms/U4Qaw7R6HtNgaBc3dEVSO6odZWh6NsVfGM=; b=ReXeIciiF4NFFhQ/IHMb4yYMIlGw4cQRP3qdhGM+219nNZPv24yYUgtPBwOjkmgo6c ZwdFIwEcVH/odn/N6q36fHsB2YJEd2OlYTTLSAJyPfwDyXnEsLekH35c5/8HH4OHVTS+ +bRNSLbWFjNLk+2TPLtrWBgVbLUz7xWK5NV48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=zkMcvSms/U4Qaw7R6HtNgaBc3dEVSO6odZWh6NsVfGM=; b=MGHZJtbl08rc3LHVba92zHq07Pdq9eZsMxHQkITgvVw4PbJYWo8DcYGb7+q8vBs73N ApHKL2iza6TmsWA+yNlxZunfJzW3OFMJ6p6/73Gz8ACMSoJ2rXT7gT4xBkF8hawHc53x h9xT7VqK2vuyAeQr7TvfHNcQUXSIsksuPn/UTSuuumfvwP/ZDtSVRxrQNjWnjXHtqpMu 3yiT9PeSe8acu3TU8xqt8kbSluSrks/9MOji8lDZm++XdVvufDjAaemmwXC3fhBEtEa2 g/Q8wKxuxkPFQ6sloIxgJ4D9Z6YpEteIHW9wZ8faHeTXHMrYiXg2qYMCq2TquCtjW4ql hUxA== X-Gm-Message-State: APjAAAW4wN/XstvFDptxW3YiZMbAXuXqA87+UdsHbQeWPGhJazrAqDhS PLlQ5r8Lw86QNtttS5L062rgEC4j9FQ= X-Google-Smtp-Source: APXvYqyS9IIRVxDZNgalOrFWi0oIEgRyORArI8t1YtTjTqwHb+ZD4S0expj0K0dwt02Xt23TJXmrPA== X-Received: by 2002:a5d:55c7:: with SMTP id i7mr23332669wrw.371.1572861003981; Mon, 04 Nov 2019 01:50:03 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id r3sm35307740wre.29.2019.11.04.01.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 01:50:03 -0800 (PST) Date: Mon, 4 Nov 2019 10:50:01 +0100 From: Daniel Vetter To: Geert Uytterhoeven Cc: Bartlomiej Zolnierkiewicz , Andrew Morton , Linux Fbdev development list , Nick Desaulniers , Linux/m68k , DRI Development , Linux Kernel Mailing List , Masahiro Yamada Subject: Re: [PATCH v2] fbdev: c2p: Fix link failure on non-inlining Message-ID: <20191104095001.GB10326@phenom.ffwll.local> Mail-Followup-To: Geert Uytterhoeven , Bartlomiej Zolnierkiewicz , Andrew Morton , Linux Fbdev development list , Nick Desaulniers , Linux/m68k , DRI Development , Linux Kernel Mailing List , Masahiro Yamada References: <20190927094708.11563-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.2.0-3-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-m68k-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Mon, Nov 04, 2019 at 08:43:07AM +0100, Geert Uytterhoeven wrote: > Hi Bartlomiej, Andrew, > > On Fri, Sep 27, 2019 at 11:47 AM Geert Uytterhoeven > wrote: > > When the compiler decides not to inline the Chunky-to-Planar core > > functions, the build fails with: > > > > c2p_planar.c:(.text+0xd6): undefined reference to `c2p_unsupported' > > c2p_planar.c:(.text+0x1dc): undefined reference to `c2p_unsupported' > > c2p_iplan2.c:(.text+0xc4): undefined reference to `c2p_unsupported' > > c2p_iplan2.c:(.text+0x150): undefined reference to `c2p_unsupported' > > > > Fix this by marking the functions __always_inline. > > > > While this could be triggered before by manually enabling both > > CONFIG_OPTIMIZE_INLINING and CONFIG_CC_OPTIMIZE_FOR_SIZE, it was exposed > > in the m68k defconfig by commit ac7c3e4ff401b304 ("compiler: enable > > CONFIG_OPTIMIZE_INLINING forcibly"). > > > > Fixes: 9012d011660ea5cf ("compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING") > > Reported-by: noreply@ellerman.id.au > > Signed-off-by: Geert Uytterhoeven > > Reviewed-by: Masahiro Yamada > > --- > > This is a fix for v5.4-rc1. > > Can you please apply this for v5.4? > This is one of the 4 remaining build regressions, compared to v5.3. Applied to drm-misc-fixes, thanks for your patch. -Daniel > > Thanks! > > > v2: > > - Add Reviewed-by, > > - Fix Fixes, > > - Add more explanation. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch