From: Kars de Jong <email@example.com> To: "James E.J. Bottomley" <firstname.lastname@example.org>, "Martin K. Petersen" <email@example.com>, Hannes Reinecke <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Kars de Jong <email@example.com> Subject: [PATCH v5 0/2] Some esp_scsi updates Date: Tue, 19 Nov 2019 21:20:19 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) When trying kernel 5.4.0-rc5 on my Amiga, I experienced data transfer failures when reading from my FAST-10 SCSI disk. I have a Blizzard 12x0 IV SCSI controller which uses a Symbios Logic SYM53CF94-2 "FSC" chip. This used to work with the old generic NCR53C9x driver, so I investigated the issue. It turned out to be caused by lacking detection of FSC silicon in the new driver. The second patch in this series adds support for the FSC. When adding support for the chip, I found out the hard way that the esp_rev enum is ordered (I just added it to the end of the enum). Then I also discovered that the definition for the PCSCSI chip was in the wrong place of the enum. It will probably have issues with FAST-10 SCSI targets, because its CONFIG3 settings are wrong. The first patch fixes this, and adds comments to the enum to hopefully prevent this from happening again. When discussing this on the Linux/m68k mailing list, it was suggested to perhaps replace the dependency on ordering of the esp_rev enum by feature flags. I did not implement this for now. Changes since v4: - Fixed style issues reported by checkpatch.pl Changes since v3: - Reduce scope of family_code variable - Remove some redundant comments - Explicitly show the NCR/Symbios Logic part code instead of FSC, which is only used in the data manual Changes since v2: - Fixed merge conflict in second patch Changes since v1: - Removed confusing comments from esp_rev enum - Remove unneeded definitions for UID register - Remove unneeded local uid variable Kars de Jong (2): esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum esp_scsi: Add support for FSC chip drivers/scsi/esp_scsi.c | 22 +++++++++++++--------- drivers/scsi/esp_scsi.h | 41 +++++++++++++++++++++++++---------------- 2 files changed, 38 insertions(+), 25 deletions(-) -- 2.17.1
next reply other threads:[~2019-11-19 20:20 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-19 20:20 Kars de Jong [this message] 2019-11-19 20:20 ` [PATCH v5 1/2] esp_scsi: Correct ordering of PCSCSI definition in esp_rev enum Kars de Jong 2019-11-19 20:20 ` [PATCH v5 2/2] esp_scsi: Add support for FSC chip Kars de Jong 2019-11-19 23:03 ` Finn Thain 2019-12-09 23:15 ` [PATCH v5 0/2] Some esp_scsi updates Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v5 0/2] Some esp_scsi updates' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).